Skip to content

Commit 73f4204

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Retier react/utils headers (#58842)
Summary: Pull Request resolved: #58842 Make `Base64.h`, `Uuid.h`, `MoveWrapper.h` and `jsi-utils.h` private, and `SimpleThreadSafeCache.h`, `OnScopeExit.h`, `FloatComparison.h`, `RunLoopObserver.h`, `LowPriorityExecutor.h`, `PackTraits.h`, `TemplateStringLiteral.h` and `iequals.h` for frameworks; drop them from `<React/Utils.h>` and include them directly where they were reached through it. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D123383902 fbshipit-source-id: f80ac3cf8c6e474bd8de711bb46831e0a88ac04f
1 parent 8d8b8f3 commit 73f4204

25 files changed

Lines changed: 29 additions & 27 deletions

File tree

‎packages/react-native/ReactCommon/jsinspector-modern/ScopedExecutor.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <React/Utils.h>
13+
#include <react/utils/OnScopeExit.h>
1314
#include <cassert>
1415
#include <functional>
1516
#include <memory>

‎packages/react-native/ReactCommon/react/renderer/components/text/platform/android/react/renderer/components/text/HostPlatformParagraphProps.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <react/renderer/core/graphicsConversions.h>
1414
#include <react/renderer/core/propsConversions.h>
1515
#include <react/renderer/debug/debugStringConvertibleUtils.h>
16+
#include <react/utils/FloatComparison.h>
1617

1718
#include <glog/logging.h>
1819

‎packages/react-native/ReactCommon/react/renderer/css/CSSBackgroundImage.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include <react/renderer/css/CSSList.h>
2323
#include <react/renderer/css/CSSPercentage.h>
2424
#include <react/renderer/css/CSSValueParser.h>
25+
#include <react/utils/iequals.h>
2526

2627
namespace facebook::react {
2728

‎packages/react-native/ReactCommon/react/renderer/css/CSSColorFunction.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <react/renderer/css/CSSNumber.h>
2222
#include <react/renderer/css/CSSPercentage.h>
2323
#include <react/renderer/css/CSSValueParser.h>
24+
#include <react/utils/PackTraits.h>
2425

2526
namespace facebook::react {
2627

‎packages/react-native/ReactCommon/react/renderer/css/CSSFilter.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
#include <react/renderer/css/CSSNumber.h>
2323
#include <react/renderer/css/CSSPercentage.h>
2424
#include <react/renderer/css/CSSZero.h>
25+
#include <react/utils/TemplateStringLiteral.h>
26+
#include <react/utils/iequals.h>
2527

2628
namespace facebook::react {
2729

‎packages/react-native/ReactCommon/react/renderer/css/CSSTransform.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
#include <react/renderer/css/CSSNumber.h>
2424
#include <react/renderer/css/CSSValueParser.h>
2525
#include <react/renderer/css/CSSZero.h>
26+
#include <react/utils/TemplateStringLiteral.h>
27+
#include <react/utils/iequals.h>
2628

2729
namespace facebook::react {
2830

‎packages/react-native/ReactCommon/react/renderer/debug/debugStringConvertibleUtils.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include <React/Utils.h>
1717
#include <react/renderer/debug/DebugStringConvertible.h>
1818
#include <react/renderer/debug/DebugStringConvertibleItem.h>
19+
#include <react/utils/FloatComparison.h>
1920

2021
namespace facebook::react {
2122

‎packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
#include <React/Utils.h>
1414
#include <react/renderer/attributedstring/AttributedString.h>
1515
#include <react/renderer/attributedstring/ParagraphAttributes.h>
16+
#include <react/utils/FloatComparison.h>
17+
#include <react/utils/SimpleThreadSafeCache.h>
1618

1719
namespace facebook::react {
1820

‎packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#include <react/renderer/textlayoutmanager/JPreparedLayout.h>
1818
#include <react/renderer/textlayoutmanager/TextLayoutContext.h>
1919
#include <react/renderer/textlayoutmanager/TextMeasureCache.h>
20+
#include <react/utils/SimpleThreadSafeCache.h>
2021

2122
#include <fbjni/fbjni.h>
2223
#include <memory>

‎packages/react-native/ReactCommon/react/utils/Base64.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <string>
1313
#include <string_view>

0 commit comments

Comments
 (0)