Add Android opt-in for RN_STRICT_API (#58849)

Summary:
Pull Request resolved: #58849

Adds a `strictCxxApiEnabled` (or `react.strictCxxApiEnabled`) Gradle property that defines `RN_STRICT_API` for an app's own native code: the app library, autolinked libraries and app codegen, through `common_flags` in `ReactNative-application.cmake`. React Native's own code is unaffected, since it defines `RN_BUILDING`. The shared precompiled header now includes React Native through module umbrellas, as its direct includes would otherwise fail under the flag. Codegen targets reuse that precompiled header, so a direct include of any header it already contains is skipped by `#pragma once` and the guards are effectively not enforced in those targets.

Changelog:
[Android][Added] - Add `strictCxxApiEnabled` Gradle property to enforce React Native's C++ stable API in app native code

Differential Revision: D123399797

Author: j-piasecki

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/NdkConfiguratorUtils.kt

@@ -12,6 +12,7 @@ import com.android.build.api.variant.Variant
 import com.facebook.react.ReactExtension
 import com.facebook.react.internal.StubPchBuildService
 import com.facebook.react.utils.ProjectUtils.getReactNativeArchitectures
+import com.facebook.react.utils.ProjectUtils.isStrictCxxApiEnabled
 import java.io.File
 import org.gradle.api.Project
 
@@ -58,6 +59,9 @@ internal object NdkConfiguratorUtils {
         if (cmakeArgs.none { it.startsWith("-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES") }) {
           cmakeArgs.add("-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON")
         }
+        if (project.isStrictCxxApiEnabled && cmakeArgs.none { it.startsWith("-DRN_STRICT_API") }) {
+          cmakeArgs.add("-DRN_STRICT_API=ON")
+        }
 
         val architectures = project.getReactNativeArchitectures()
         // abiFilters are split ABI are not compatible each other, so we set the abiFilters

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/ProjectUtils.kt

@@ -15,7 +15,9 @@ import com.facebook.react.utils.PropertyUtils.REACT_NATIVE_ARCHITECTURES
 import com.facebook.react.utils.PropertyUtils.SCOPED_EDGE_TO_EDGE_ENABLED
 import com.facebook.react.utils.PropertyUtils.SCOPED_HERMES_ENABLED
 import com.facebook.react.utils.PropertyUtils.SCOPED_REACT_NATIVE_ARCHITECTURES
+import com.facebook.react.utils.PropertyUtils.SCOPED_STRICT_CXX_API_ENABLED
 import com.facebook.react.utils.PropertyUtils.SCOPED_USE_THIRD_PARTY_JSC
+import com.facebook.react.utils.PropertyUtils.STRICT_CXX_API_ENABLED
 import com.facebook.react.utils.PropertyUtils.USE_THIRD_PARTY_JSC
 import org.gradle.api.Project
 import org.gradle.api.file.DirectoryProperty
@@ -56,6 +58,13 @@ internal object ProjectUtils {
             (project.hasProperty(SCOPED_EDGE_TO_EDGE_ENABLED) &&
                 project.property(SCOPED_EDGE_TO_EDGE_ENABLED).toString().toBoolean())
 
+  internal val Project.isStrictCxxApiEnabled: Boolean
+    get() =
+        (project.hasProperty(STRICT_CXX_API_ENABLED) &&
+            project.property(STRICT_CXX_API_ENABLED).toString().toBoolean()) ||
+            (project.hasProperty(SCOPED_STRICT_CXX_API_ENABLED) &&
+                project.property(SCOPED_STRICT_CXX_API_ENABLED).toString().toBoolean())
+
   internal val Project.useThirdPartyJSC: Boolean
     get() =
         (project.hasProperty(USE_THIRD_PARTY_JSC) &&

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PropertyUtils.kt

@@ -29,6 +29,13 @@ object PropertyUtils {
   const val EDGE_TO_EDGE_ENABLED = "edgeToEdgeEnabled"
   const val SCOPED_EDGE_TO_EDGE_ENABLED = "react.edgeToEdgeEnabled"
 
+  /**
+   * Public property that enforces the C++ stable API for the app's own native code by defining
+   * RN_STRICT_API
+   */
+  const val STRICT_CXX_API_ENABLED = "strictCxxApiEnabled"
+  const val SCOPED_STRICT_CXX_API_ENABLED = "react.strictCxxApiEnabled"
+
   /** Public property that excludes jsctooling from core */
   const val USE_THIRD_PARTY_JSC = "useThirdPartyJSC"
   const val SCOPED_USE_THIRD_PARTY_JSC = "react.useThirdPartyJSC"

packages/gradle-plugin/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/ProjectUtilsTest.kt

@@ -15,6 +15,7 @@ import com.facebook.react.utils.ProjectUtils.getReactNativeArchitectures
 import com.facebook.react.utils.ProjectUtils.isEdgeToEdgeEnabled
 import com.facebook.react.utils.ProjectUtils.isHermesEnabled
 import com.facebook.react.utils.ProjectUtils.isNewArchEnabled
+import com.facebook.react.utils.ProjectUtils.isStrictCxxApiEnabled
 import com.facebook.react.utils.ProjectUtils.needsCodegenFromPackageJson
 import java.io.File
 import org.assertj.core.api.Assertions.assertThat
@@ -115,6 +116,39 @@ class ProjectUtilsTest {
     assertThat(project.isEdgeToEdgeEnabled).isFalse()
   }
 
+  @Test
+  fun isStrictCxxApiEnabled_returnsFalseByDefault() {
+    assertThat(createProject().isStrictCxxApiEnabled).isFalse()
+  }
+
+  @Test
+  fun isStrictCxxApiEnabled_withEnabledViaProperty_returnsTrue() {
+    val project = createProject()
+    project.extensions.extraProperties.set("strictCxxApiEnabled", "true")
+    assertThat(project.isStrictCxxApiEnabled).isTrue()
+  }
+
+  @Test
+  fun isStrictCxxApiEnabled_withEnabledViaScopedProperty_returnsTrue() {
+    val project = createProject()
+    project.extensions.extraProperties.set("react.strictCxxApiEnabled", "true")
+    assertThat(project.isStrictCxxApiEnabled).isTrue()
+  }
+
+  @Test
+  fun isStrictCxxApiEnabled_withDisabledViaProperty_returnsFalse() {
+    val project = createProject()
+    project.extensions.extraProperties.set("strictCxxApiEnabled", "false")
+    assertThat(project.isStrictCxxApiEnabled).isFalse()
+  }
+
+  @Test
+  fun isStrictCxxApiEnabled_withInvalidViaProperty_returnsFalse() {
+    val project = createProject()
+    project.extensions.extraProperties.set("strictCxxApiEnabled", "¯\\_(ツ)_/¯")
+    assertThat(project.isStrictCxxApiEnabled).isFalse()
+  }
+
   @Test
   fun needsCodegenFromPackageJson_withCodegenConfigInPackageJson_returnsTrue() {
     val project = createProject()

packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake

@@ -89,6 +89,11 @@ target_link_libraries(${CMAKE_PROJECT_NAME}
 add_library(common_flags INTERFACE)
 target_compile_options(common_flags INTERFACE ${folly_FLAGS})
 
+if(RN_STRICT_API)
+        target_compile_definitions(common_flags INTERFACE RN_STRICT_API)
+        target_compile_definitions(${CMAKE_PROJECT_NAME} PRIVATE RN_STRICT_API)
+endif()
+
 # Defines the `reactnative_pch` target and `target_reuse_reactnative_pch()`, so
 # the codegen targets below share a single precompiled header. Has to come after
 # `common_flags`, as the precompiled header is built with the same flags as its

packages/react-native/ReactAndroid/cmake-utils/precompiled-header/pch.h

@@ -7,15 +7,10 @@
 
 #pragma once
 
-#include <ReactCommon/JavaTurboModule.h>
-#include <ReactCommon/TurboModule.h>
+#include <React/Bridging.h>
+#include <React/ComponentRegistry.h>
+#include <React/NativeModuleCore.h>
+#include <React/RendererCore.h>
+#include <React/View.h>
 #include <folly/dynamic.h>
 #include <jsi/jsi.h>
-#include <react/bridging/Bridging.h>
-#include <react/renderer/componentregistry/ComponentDescriptorProviderRegistry.h>
-#include <react/renderer/components/view/ConcreteViewShadowNode.h>
-#include <react/renderer/components/view/ViewEventEmitter.h>
-#include <react/renderer/core/ConcreteComponentDescriptor.h>
-#include <react/renderer/core/PropsParserContext.h>
-#include <react/renderer/core/StateData.h>
-#include <react/renderer/core/propsConversions.h>