Commit 832f368
Resolve umbrella headers in CMake builds
Summary:
The `React/*.h` umbrella headers for `react/renderer/components/view`, `react/debug` and `react/renderer/mapbuffer` are exported by every build system except CMake, so `#include <React/View.h>`, `<React/Debug.h>` and `<React/MapBuffer.h>` fail to resolve there.
Add the missing `target_include_directories(<target> INTERFACE ...)` entry to each module, matching what the other umbrella-exporting modules already do.
Changelog:
[Android][Fixed] - Make the `React/View.h`, `React/Debug.h` and `React/MapBuffer.h` umbrella headers resolvable in CMake builds
Differential Revision: D1196620871 parent 8480b86 commit 832f368
3 files changed
Lines changed: 3 additions & 0 deletions
File tree
- packages/react-native/ReactCommon/react
- debug
- renderer
- components/view
- mapbuffer
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
0 commit comments