Repository navigation
Commit 88a8bd2
Tweak LogBox notifications for iPhone Duo, fix rail touches (#58958)
Summary:
Minimal fixes to the LogBox notification toasts for the iPhone Duo, where they stretch across the unfolded display and block the tab bar beside them when folded.
- Cap the toasts at 600pt wide and center them, so they no longer span the unfolded display edge to edge.
- **Fix**: Pass touches outside the toasts through to the app, so the folded Duo's rail tab bar beside them stays tappable.
- **Fix**: Raise the dismiss ×'s contrast from about 2.5:1 to about 7:1. Previously, it drew in the toast's own color on a mid-gray circle and read as **faint/invisible**; the icon is unchanged.
- **Tweak**: Round corners from 8 to 12px.
| Before | After |
|---|---|
| <img src="https://github.com/user-attachments/assets/612d33c1-8d93-4a47-8bd5-5d3c118fb5c4" width="400" /> | <img src="https://github.com/user-attachments/assets/ae436c7d-06b6-4f7f-a07c-5ee7cbe51aef" width="400" /> |
Changelog:
[General][Fixed] - **LogBox**: Fix bottom notification appearance/touch targets on iPhone Duo
Pull Request resolved: #58958
Test Plan:
```
yarn test packages/react-native/Libraries/LogBox
```
**iPhone Duo, folded**
| Before | Before, tab bar blocked | After |
|---|---|---|
| <img src=--sanitized--
Reviewed By: vzaidman
Differential Revision: D124115690
Pulled By: Abbondanzo
fbshipit-source-id: 0844b21f898d309eff50235147dc5f0bb8b9ca3e1 parent a948811 commit 88a8bd2
3 files changed
Lines changed: 28 additions & 8 deletions
File tree
- packages/react-native/Libraries/LogBox
- UI
- __tests__/__snapshots__
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
| 114 | + | |
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
120 | | - | |
| 124 | + | |
121 | 125 | | |
| 126 | + | |
122 | 127 | | |
| 128 | + | |
123 | 129 | | |
124 | 130 | | |
125 | 131 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
| 27 | + | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | | - | |
| 19 | + | |
18 | 20 | | |
| 21 | + | |
19 | 22 | | |
| 23 | + | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
| |||
59 | 63 | | |
60 | 64 | | |
61 | 65 | | |
62 | | - | |
| 66 | + | |
63 | 67 | | |
| 68 | + | |
64 | 69 | | |
| 70 | + | |
65 | 71 | | |
66 | 72 | | |
67 | 73 | | |
| |||
116 | 122 | | |
117 | 123 | | |
118 | 124 | | |
| 125 | + | |
119 | 126 | | |
120 | 127 | | |
| 128 | + | |
121 | 129 | | |
122 | 130 | | |
123 | 131 | | |
| |||
126 | 134 | | |
127 | 135 | | |
128 | 136 | | |
129 | | - | |
| 137 | + | |
130 | 138 | | |
| 139 | + | |
131 | 140 | | |
| 141 | + | |
132 | 142 | | |
133 | 143 | | |
134 | 144 | | |
| |||
175 | 185 | | |
176 | 186 | | |
177 | 187 | | |
| 188 | + | |
178 | 189 | | |
179 | 190 | | |
| 191 | + | |
180 | 192 | | |
181 | 193 | | |
182 | 194 | | |
| |||
185 | 197 | | |
186 | 198 | | |
187 | 199 | | |
188 | | - | |
| 200 | + | |
189 | 201 | | |
| 202 | + | |
190 | 203 | | |
| 204 | + | |
191 | 205 | | |
192 | 206 | | |
193 | 207 | | |
| |||
0 commit comments