Skip to content

Commit 8f9232b

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover textlayoutmanager with Stable API guards (#58312)
Summary: Pull Request resolved: #58312 Classifies `react/renderer/textlayoutmanager:textlayoutmanager` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118630817 fbshipit-source-id: 7e73e1db43e380be3af20470ee19525bbac15342
1 parent ff3ea5e commit 8f9232b

14 files changed

Lines changed: 27 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ target_link_libraries(react_renderer_textlayoutmanager
3838
${fbjni}
3939
folly_runtime
4040
${mapbufferjni}
41+
react_cxxstableapi
4142
react_debug
4243
react_renderer_attributedstring
4344
react_renderer_componentregistry

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextLayoutContext.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/core/ReactPrimitives.h>
1113
#include <react/renderer/graphics/Float.h>
1214

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextLayoutManagerExtended.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <glog/logging.h>
1113
#include <cstddef>
1214

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/attributedstring/AttributedString.h>
1113
#include <react/renderer/attributedstring/ParagraphAttributes.h>
1214
#include <react/renderer/core/LayoutConstraints.h>

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/TextMeasurementRounding.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <cmath>
1113

1214
#include <react/renderer/graphics/Size.h>

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/JPreparedLayout.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <fbjni/fbjni.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/jni/SafeReleaseJniRef.h>
1113
#include <react/renderer/attributedstring/AttributedStringBox.h>
1214
#include <react/renderer/attributedstring/ParagraphAttributes.h>

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/cxx/react/renderer/textlayoutmanager/TextLayoutManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <react/renderer/attributedstring/AttributedStringBox.h>
1113
#include <react/renderer/attributedstring/ParagraphAttributes.h>
1214
#include <react/renderer/core/LayoutConstraints.h>

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTAttributedTextUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
#import <UIKit/UIKit.h>
911

1012
#include <react/renderer/attributedstring/AttributedString.h>

packages/react-native/ReactCommon/react/renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTFontProperties.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#include <react/cxxstableapi/FrameworksGuard.h>
9+
810
#import <UIKit/UIKit.h>
911

1012
NS_ASSUME_NONNULL_BEGIN

0 commit comments

Comments
 (0)