Skip to content

Commit 923bb33

Browse files
j-piaseckimeta-codesync[bot]
j-piasecki
authored and
meta-codesync[bot]
committed
Make internal reactperflogger headers private (#58840)
Summary: Pull Request resolved: #58840 Switch `BridgeNativeModulePerfLogger.h`, `FuseboxTracer.h`, `FuseboxPerfettoDataSource.h`, `HermesPerfettoDataSource.h`, `ReactPerfetto.h` and `ReactPerfettoLogger.h` to `PrivateGuard.h`. `NativeModulePerfLogger.h` and `ReactPerfettoCategories.h` stay for frameworks. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D123379537 fbshipit-source-id: 01240d55a68a50e859baf46558b7a7b7d8e3301b
1 parent 840891d commit 923bb33

9 files changed

Lines changed: 6 additions & 204 deletions

File tree

‎packages/react-native/ReactCommon/reactperflogger/fusebox/FuseboxTracer.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include "folly/json/dynamic.h"
1313

‎packages/react-native/ReactCommon/reactperflogger/reactperflogger/BridgeNativeModulePerfLogger.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <memory>
1313
#include "NativeModulePerfLogger.h"

‎packages/react-native/ReactCommon/reactperflogger/reactperflogger/FuseboxPerfettoDataSource.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#ifdef WITH_PERFETTO
1313

‎packages/react-native/ReactCommon/reactperflogger/reactperflogger/HermesPerfettoDataSource.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#ifdef WITH_PERFETTO
1313

‎packages/react-native/ReactCommon/reactperflogger/reactperflogger/ReactPerfetto.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#ifdef WITH_PERFETTO
1313

‎packages/react-native/ReactCommon/reactperflogger/reactperflogger/ReactPerfettoLogger.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/FrameworksGuard.h>
10+
#include <react/cxxstableapi/PrivateGuard.h>
1111

1212
#include <React/Timing.h>
1313
#include <reactperflogger/ReactPerfettoCategories.h>

‎scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -1986,16 +1986,6 @@ class facebook::react::FocusOrderingHelper {
19861986
public static void traverseAndUpdateNextFocusableElement(const std::shared_ptr<const facebook::react::ShadowNode>& parentShadowNode, const std::shared_ptr<const facebook::react::ShadowNode>& focusedShadowNode, const std::shared_ptr<const facebook::react::ShadowNode>& currNode, facebook::react::FocusDirection focusDirection, const facebook::react::UIManager& uimanager, facebook::react::Rect sourceRect, std::optional<facebook::react::Rect>& nextRect, std::shared_ptr<const facebook::react::ShadowNode>& nextNode);
19871987
}
19881988

1989-
class facebook::react::FuseboxTracer {
1990-
public FuseboxTracer(const facebook::react::FuseboxTracer&) = delete;
1991-
public bool isTracing();
1992-
public bool startTracing();
1993-
public bool stopTracing(const std::function<void(const folly::dynamic& eventsChunk)>& resultCallback);
1994-
public bool stopTracingAndWriteToFile(const std::string& path);
1995-
public static facebook::react::FuseboxTracer& getFuseboxTracer();
1996-
public void addEvent(const std::string_view& name, uint64_t start, uint64_t end, const std::optional<std::string_view>& track);
1997-
}
1998-
19991989
class facebook::react::HermesInstance {
20001990
public static std::unique_ptr<JSRuntime> createJSRuntime(std::shared_ptr<hermes::vm::CrashManager> crashManager, std::shared_ptr<facebook::react::MessageQueueThread> msgQueueThread, bool allocInOldGenBeforeTTI) noexcept;
20011991
}
@@ -3391,12 +3381,6 @@ struct facebook::react::ReactInstance::JSRuntimeFlags {
33913381
public const std::string runtimeDiagnosticFlags;
33923382
}
33933383

3394-
class facebook::react::ReactPerfettoLogger {
3395-
public static bool isTracing();
3396-
public static void mark(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
3397-
public static void measure(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, facebook::react::HighResTimeStamp endTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
3398-
}
3399-
34003384
class facebook::react::ReadableNativeArray : public jni::HybridClass<facebook::react::ReadableNativeArray, facebook::react::NativeArray> {
34013385
protected friend HybridBase;
34023386
public bool equals(jni::alias_ref<ReadableNativeArray::javaobject> other);
@@ -5754,13 +5738,6 @@ struct facebook::react::Bridging<void> {
57545738
public static void fromJs(facebook::jsi::Runtime&, const facebook::jsi::Value&);
57555739
}
57565740

5757-
struct facebook::react::BufferEvent {
5758-
public std::string name;
5759-
public std::string track;
5760-
public uint64_t end;
5761-
public uint64_t start;
5762-
}
5763-
57645741
struct facebook::react::BundleHeader {
57655742
public BundleHeader();
57665743
public facebook::react::Magic32 magic32;
@@ -10048,49 +10025,6 @@ struct facebook::react::ReactMarker::ReactMarkerEvent {
1004810025
}
1004910026

1005010027

10051-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
10052-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
10053-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessEnd(int batchSize);
10054-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessStart();
10055-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallDispatch(const char* moduleName, const char* methodName);
10056-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallEnd(const char* moduleName, const char* methodName);
10057-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionEnd(const char* moduleName, const char* methodName, int32_t id);
10058-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionStart(const char* moduleName, const char* methodName, int32_t id);
10059-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionEnd(const char* moduleName, const char* methodName, int32_t id);
10060-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionFail(const char* moduleName, const char* methodName, int32_t id);
10061-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionStart(const char* moduleName, const char* methodName, int32_t id);
10062-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallFail(const char* moduleName, const char* methodName);
10063-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallStart(const char* moduleName, const char* methodName);
10064-
void facebook::react::BridgeNativeModulePerfLogger::disableLogging();
10065-
void facebook::react::BridgeNativeModulePerfLogger::enableLogging(std::unique_ptr<facebook::react::NativeModulePerfLogger>&& logger);
10066-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateCacheHit(const char* moduleName, int32_t id);
10067-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructEnd(const char* moduleName, int32_t id);
10068-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructStart(const char* moduleName, int32_t id);
10069-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateEnd(const char* moduleName, int32_t id);
10070-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateFail(const char* moduleName, int32_t id);
10071-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpEnd(const char* moduleName, int32_t id);
10072-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpStart(const char* moduleName, int32_t id);
10073-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateStart(const char* moduleName, int32_t id);
10074-
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateEnd(const char* moduleName, int32_t id);
10075-
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateStart(const char* moduleName, int32_t id);
10076-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningCacheHit(const char* moduleName);
10077-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningEnd(const char* moduleName);
10078-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningFail(const char* moduleName);
10079-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningStart(const char* moduleName);
10080-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingEnd(const char* moduleName);
10081-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingFail(const char* moduleName);
10082-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingStart(const char* moduleName);
10083-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
10084-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
10085-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallEnd(const char* moduleName, const char* methodName);
10086-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionEnd(const char* moduleName, const char* methodName);
10087-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionStart(const char* moduleName, const char* methodName);
10088-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallFail(const char* moduleName, const char* methodName);
10089-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionEnd(const char* moduleName, const char* methodName);
10090-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionStart(const char* moduleName, const char* methodName);
10091-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallStart(const char* moduleName, const char* methodName);
10092-
10093-
1009410028
void facebook::react::LowPriorityExecutor::execute(std::function<void()>&& workItem);
1009510029

1009610030

‎scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -4443,16 +4443,6 @@ class facebook::react::EventTarget {
44434443
public void setEnabled(bool enabled);
44444444
}
44454445

4446-
class facebook::react::FuseboxTracer {
4447-
public FuseboxTracer(const facebook::react::FuseboxTracer&) = delete;
4448-
public bool isTracing();
4449-
public bool startTracing();
4450-
public bool stopTracing(const std::function<void(const folly::dynamic& eventsChunk)>& resultCallback);
4451-
public bool stopTracingAndWriteToFile(const std::string& path);
4452-
public static facebook::react::FuseboxTracer& getFuseboxTracer();
4453-
public void addEvent(const std::string_view& name, uint64_t start, uint64_t end, const std::optional<std::string_view>& track);
4454-
}
4455-
44564446
class facebook::react::HermesInstance {
44574447
public static std::unique_ptr<facebook::react::JSRuntime> createJSRuntime(std::shared_ptr<hermes::vm::CrashManager> crashManager, std::shared_ptr<facebook::react::MessageQueueThread> msgQueueThread, bool allocInOldGenBeforeTTI) noexcept;
44584448
}
@@ -5613,12 +5603,6 @@ struct facebook::react::ReactInstance::JSRuntimeFlags {
56135603
public const std::string runtimeDiagnosticFlags;
56145604
}
56155605

5616-
class facebook::react::ReactPerfettoLogger {
5617-
public static bool isTracing();
5618-
public static void mark(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
5619-
public static void measure(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, facebook::react::HighResTimeStamp endTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
5620-
}
5621-
56225606
class facebook::react::RootProps : public facebook::react::HostPlatformViewProps {
56235607
public RootProps() = default;
56245608
public RootProps(const facebook::react::PropsParserContext& context, const facebook::react::RootProps& sourceProps, const facebook::react::LayoutConstraints& layoutConstraints, const facebook::react::LayoutContext& layoutContext);
@@ -7937,13 +7921,6 @@ struct facebook::react::Bridging<void> {
79377921
public static void fromJs(facebook::jsi::Runtime&, const facebook::jsi::Value&);
79387922
}
79397923

7940-
struct facebook::react::BufferEvent {
7941-
public std::string name;
7942-
public std::string track;
7943-
public uint64_t end;
7944-
public uint64_t start;
7945-
}
7946-
79477924
struct facebook::react::BundleHeader {
79487925
public BundleHeader();
79497926
public facebook::react::Magic32 magic32;
@@ -11891,49 +11868,6 @@ struct facebook::react::ReactMarker::ReactMarkerEvent {
1189111868
}
1189211869

1189311870

11894-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
11895-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
11896-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessEnd(int batchSize);
11897-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessStart();
11898-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallDispatch(const char* moduleName, const char* methodName);
11899-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallEnd(const char* moduleName, const char* methodName);
11900-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionEnd(const char* moduleName, const char* methodName, int32_t id);
11901-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionStart(const char* moduleName, const char* methodName, int32_t id);
11902-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionEnd(const char* moduleName, const char* methodName, int32_t id);
11903-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionFail(const char* moduleName, const char* methodName, int32_t id);
11904-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionStart(const char* moduleName, const char* methodName, int32_t id);
11905-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallFail(const char* moduleName, const char* methodName);
11906-
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallStart(const char* moduleName, const char* methodName);
11907-
void facebook::react::BridgeNativeModulePerfLogger::disableLogging();
11908-
void facebook::react::BridgeNativeModulePerfLogger::enableLogging(std::unique_ptr<facebook::react::NativeModulePerfLogger>&& logger);
11909-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateCacheHit(const char* moduleName, int32_t id);
11910-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructEnd(const char* moduleName, int32_t id);
11911-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructStart(const char* moduleName, int32_t id);
11912-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateEnd(const char* moduleName, int32_t id);
11913-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateFail(const char* moduleName, int32_t id);
11914-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpEnd(const char* moduleName, int32_t id);
11915-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpStart(const char* moduleName, int32_t id);
11916-
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateStart(const char* moduleName, int32_t id);
11917-
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateEnd(const char* moduleName, int32_t id);
11918-
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateStart(const char* moduleName, int32_t id);
11919-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningCacheHit(const char* moduleName);
11920-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningEnd(const char* moduleName);
11921-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningFail(const char* moduleName);
11922-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningStart(const char* moduleName);
11923-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingEnd(const char* moduleName);
11924-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingFail(const char* moduleName);
11925-
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingStart(const char* moduleName);
11926-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
11927-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
11928-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallEnd(const char* moduleName, const char* methodName);
11929-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionEnd(const char* moduleName, const char* methodName);
11930-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionStart(const char* moduleName, const char* methodName);
11931-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallFail(const char* moduleName, const char* methodName);
11932-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionEnd(const char* moduleName, const char* methodName);
11933-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionStart(const char* moduleName, const char* methodName);
11934-
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallStart(const char* moduleName, const char* methodName);
11935-
11936-
1193711871
void facebook::react::LowPriorityExecutor::execute(std::function<void()>&& workItem);
1193811872

1193911873

0 commit comments

Comments
 (0)