Skip to content

Commit 9b87159

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Do not fail superseded Maestro Cloud runs (#58422)
Summary: Treat Maestro Cloud uploads stopped by a newer upload as successfully superseded instead of failing the GitHub Actions job. The action still fails the job for test failures, timeouts, and errors, including failures where no upload status is available. This allows the Maestro Cloud “Stop Previous Flows” setting to be re-enabled without creating failure tasks for intentionally superseded runs. Re-enabling that project setting remains a separate dashboard operation. ## Changelog: [INTERNAL] [FIXED] - Do not fail CI when a Maestro Cloud run is superseded Pull Request resolved: #58422 Test Plan: - `git diff --check` — passed - `./node_modules/.bin/prettier --check .github/workflows/maestro-cloud-rntester.yml` — passed - Exercised the result gate for STOPPED, ERROR, missing-status failure, and SUCCESS outcomes — passed Reviewed By: cipolleschi Differential Revision: D119329958 Pulled By: cortinico fbshipit-source-id: 94dd5efba87f2a9af7261daaee146f839ade380d
1 parent ca7acf6 commit 9b87159

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

‎.github/workflows/maestro-cloud-rntester.yml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ jobs:
6060
test -n "$MAESTRO_CLOUD_PROJECT_ID"
6161
test -z "$(find packages/rn-tester/.maestro -type l -print -quit)"
6262
- name: Run flows on Maestro Cloud
63+
id: maestro-cloud
64+
continue-on-error: true
6365
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
6466
with:
6567
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
@@ -73,3 +75,15 @@ jobs:
7375
APP_ID=${{ inputs.app-id }}
7476
maestro-cli-version: 2.6.1
7577
timeout: 60
78+
- name: Check Maestro Cloud result
79+
if: always()
80+
env:
81+
MAESTRO_CLOUD_OUTCOME: ${{ steps.maestro-cloud.outcome }}
82+
MAESTRO_CLOUD_UPLOAD_STATUS: ${{ steps.maestro-cloud.outputs.MAESTRO_CLOUD_UPLOAD_STATUS }}
83+
run: |
84+
if [[ "$MAESTRO_CLOUD_UPLOAD_STATUS" == "STOPPED" ]]; then
85+
echo "::notice::Maestro Cloud run was superseded by a newer upload"
86+
elif [[ "$MAESTRO_CLOUD_OUTCOME" == "failure" ]]; then
87+
echo "::error::Maestro Cloud failed with status ${MAESTRO_CLOUD_UPLOAD_STATUS:-UNKNOWN}"
88+
exit 1
89+
fi

0 commit comments

Comments
 (0)