Skip to content

Commit a385cec

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Drop unused Hermes import from RCTAppSetupUtils (#58056)
Summary: Pull Request resolved: #58056 `RCTAppSetupUtils.h` imports `<reacthermes/HermesExecutorFactory.h>` but names nothing from it, so the import and the conditional that wrapped only it are removed. This unblocks classifying the Hermes executor as a private target under the three-tier C++ stable API visibility model, which it cannot be while a public header reaches it. Code that relied on reaching `HermesExecutorFactory` through this header should import it directly. Changelog: [iOS][Changed] - `RCTAppSetupUtils.h` no longer transitively imports `HermesExecutorFactory.h` Reviewed By: javache Differential Revision: D116934198 fbshipit-source-id: f1d6c82cb658cfdbc0581b6132ae3516982a1b75
1 parent 25c5539 commit a385cec

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

packages/react-native/Libraries/AppDelegate/RCTAppSetupUtils.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313

1414
#import <memory>
1515

16-
#if USE_THIRD_PARTY_JSC != 1
17-
#import <reacthermes/HermesExecutorFactory.h>
18-
#endif
19-
2016
#import <ReactCommon/RCTTurboModuleManager.h>
2117
#import <jsireact/JSIExecutor.h>
2218

0 commit comments

Comments
 (0)