Simplify scheme newline tests

Author: chrfalch

packages/react-native/scripts/spm/__tests__/generate-spm-xcodeproj-test.js

@@ -139,15 +139,10 @@ describe('scheme pre-action', () => {
   });
 
   function parsedSyncScript(xml) {
-    const contents = new DOMParser()
+    return new DOMParser()
       .parseFromString(xml, 'text/xml')
-      .getElementsByTagName('ActionContent');
-    for (let i = 0; i < contents.length; i++) {
-      if (contents[i].getAttribute('title') === 'Sync SPM Autolinking') {
-        return contents[i].getAttribute('scriptText');
-      }
-    }
-    return null;
+      .getElementsByTagName('ActionContent')[0]
+      .getAttribute('scriptText');
   }
 
   const MULTILINE_SCRIPT = 'set -e\n\tif [ "$A" ]; then\r\n  a && b < c\nfi';
@@ -174,7 +169,6 @@ describe('scheme pre-action', () => {
       'TARGET_UUID',
       MULTILINE_SCRIPT,
     );
-    expect(updated).toContain('&#10;');
     expect(parsedSyncScript(updated)).toBe(MULTILINE_SCRIPT);
   });
 

packages/react-native/scripts/spm/__tests__/remove-spm-injection-test.js

@@ -505,10 +505,9 @@ describe('deinit — scheme ownership', () => {
     sync();
     fs.writeFileSync(
       schemePath,
-      readScheme()
-        .replace(/
/g, '\n')
-        .replace(/
/g, '\r')
-        .replace(/	/g, '\t'),
+      readScheme().replace(/&#(9|10|13);/g, (_, c) =>
+        String.fromCharCode(Number(c)),
+      ),
       'utf8',
     );
 

packages/react-native/scripts/spm/generate-spm-xcodeproj.js

@@ -2518,11 +2518,8 @@ function injectSpmIntoExistingXcodeproj(
   return {status: 'injected', target: plan.target.name};
 }
 
-/**
- * The scheme with the sync pre-action's scriptText emptied, or null when the
- * scheme has none. Cutting the raw value keeps the comparison independent of
- * how an older RN version encoded the script.
- */
+// The scheme with the sync pre-action's scriptText emptied, so the compare
+// ignores how the script was encoded; null when there is no pre-action.
 function withoutPreActionScript(xml /*: string */) /*: ?string */ {
   const titleIdx = xml.indexOf('title = "Sync SPM Autolinking"');
   if (titleIdx < 0) {