Repository navigation
Commit bf1258e
Make Image component implementation headers for-frameworks (#58875)
Summary:
Pull Request resolved: #58875
Lower `ImageComponentDescriptor.h`, `ImageShadowNode.h`, `ImageProps.h`, `ImageState.h` and `ImageEventEmitter.h` in `react/renderer/components/image` from public to "for frameworks". They implement the built-in `<Image>` component and are consumed by hosts that register core components and by platform image renderers, not by app code. This matches the tiering of the `text`, `scrollview` and `root` component modules.
`conversions.h` stays public and is now the only header in the `<React/Image.h>` umbrella: code generated for a component with an `ImageSource` prop includes `<React/Image.h>` and relies on its `fromRawValue(..., ImageSource &)` overload through `convertRawProp`.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D123593354
fbshipit-source-id: 6dc40b2ff027fa344e6138db50d0477f212133691 parent a96d7fe commit bf1258e
6 files changed
Lines changed: 5 additions & 10 deletions
File tree
- packages/react-native/ReactCommon/react/renderer/components/image
- React
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 34 | | |
40 | 35 | | |
41 | 36 | | |
| |||
0 commit comments