Move multi-source image disk cache checks off the UI thread (#58701)

Summary:
Pull Request resolved: #58701

Avoid synchronous disk I/O while Android selects a source for multi-source images. The best source and bitmap-memory-cache preview are selected immediately. More precise alternate sources are ordered by size precision and submitted as a first-available disk-cache-only intermediate request, so Fresco probes them off the UI thread alongside the primary request while preserving the immediate memory preview.

Both Android image-view implementations submit one controller/show request immediately without asynchronous view callbacks or duplicate lifecycles. Drawee snapshots controller instrumentation once per request before its fallback suppliers run. The behavior remains behind a disabled-by-default runtime gate.

Changelog:
[Android][Fixed] - Avoid blocking the UI thread while selecting multi-source images

Reviewed By: javache

Differential Revision: D122082126

fbshipit-source-id: 673ecc856f00e9165bf0199c4f4df9e1f29765f4

Author: Abbondanzo

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<759fe2f98c26a288f8cd281027aad237>>
+ * @generated SignedSource<<a7ee8533698805217e86f58648598578>>
  */
 
 /**
@@ -120,6 +120,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableAndroidTextMeasurementOptimizations(): Boolean = accessor.enableAndroidTextMeasurementOptimizations()
 
+  /**
+   * Runs multi-source image disk-cache checks asynchronously on Android.
+   */
+  @JvmStatic
+  public fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean = accessor.enableAsyncDiskCacheCheckInMultiSourceImageAndroid()
+
   /**
    * Feature flag to enable the new bridgeless architecture.
    */

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<1f2c6af3ce83f8f56e6fef3eece891bd>>
+ * @generated SignedSource<<76f45f25d630cf505f8628e125ab8904>>
  */
 
 /**
@@ -35,6 +35,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
   private var enableAccumulatedUpdatesInRawPropsAndroidCache: Boolean? = null
   private var enableAndroidAutoOffscreenCompositingForElevationCache: Boolean? = null
   private var enableAndroidTextMeasurementOptimizationsCache: Boolean? = null
+  private var enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache: Boolean? = null
   private var enableBridgelessArchitectureCache: Boolean? = null
   private var enableCppPropsIteratorSetterCache: Boolean? = null
   private var enableCustomFocusSearchOnClippedElementsAndroidCache: Boolean? = null
@@ -245,6 +246,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
     return cached
   }
 
+  override fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean {
+    var cached = enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache
+    if (cached == null) {
+      cached = ReactNativeFeatureFlagsCxxInterop.enableAsyncDiskCacheCheckInMultiSourceImageAndroid()
+      enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache = cached
+    }
+    return cached
+  }
+
   override fun enableBridgelessArchitecture(): Boolean {
     var cached = enableBridgelessArchitectureCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<9fe9b6af3dd1aba706dd87a8dd0a9c57>>
+ * @generated SignedSource<<65ff63eb491771b462831024fafe8078>>
  */
 
 /**
@@ -58,6 +58,8 @@ public object ReactNativeFeatureFlagsCxxInterop {
 
   @DoNotStrip @JvmStatic public external fun enableAndroidTextMeasurementOptimizations(): Boolean
 
+  @DoNotStrip @JvmStatic public external fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean
+
   @DoNotStrip @JvmStatic public external fun enableBridgelessArchitecture(): Boolean
 
   @DoNotStrip @JvmStatic public external fun enableCppPropsIteratorSetter(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<1e15400f6b519fc8e9cd3e576501e7ed>>
+ * @generated SignedSource<<e3f3716e403f03fc67e73fc6db6904ac>>
  */
 
 /**
@@ -53,6 +53,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
 
   override fun enableAndroidTextMeasurementOptimizations(): Boolean = false
 
+  override fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean = false
+
   override fun enableBridgelessArchitecture(): Boolean = true
 
   override fun enableCppPropsIteratorSetter(): Boolean = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<5f805273ebd792ecec1c284ca074e190>>
+ * @generated SignedSource<<c6b4968eaf615dddef9fed75960f44aa>>
  */
 
 /**
@@ -39,6 +39,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
   private var enableAccumulatedUpdatesInRawPropsAndroidCache: Boolean? = null
   private var enableAndroidAutoOffscreenCompositingForElevationCache: Boolean? = null
   private var enableAndroidTextMeasurementOptimizationsCache: Boolean? = null
+  private var enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache: Boolean? = null
   private var enableBridgelessArchitectureCache: Boolean? = null
   private var enableCppPropsIteratorSetterCache: Boolean? = null
   private var enableCustomFocusSearchOnClippedElementsAndroidCache: Boolean? = null
@@ -264,6 +265,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
     return cached
   }
 
+  override fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean {
+    var cached = enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache
+    if (cached == null) {
+      cached = currentProvider.enableAsyncDiskCacheCheckInMultiSourceImageAndroid()
+      accessedFeatureFlags.add("enableAsyncDiskCacheCheckInMultiSourceImageAndroid")
+      enableAsyncDiskCacheCheckInMultiSourceImageAndroidCache = cached
+    }
+    return cached
+  }
+
   override fun enableBridgelessArchitecture(): Boolean {
     var cached = enableBridgelessArchitectureCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<c2c4ed4f4bca0b82aefc82dfb43617b7>>
+ * @generated SignedSource<<62d4a09fa162c10b27df8143e905375b>>
  */
 
 /**
@@ -53,6 +53,8 @@ public interface ReactNativeFeatureFlagsProvider {
 
   @DoNotStrip public fun enableAndroidTextMeasurementOptimizations(): Boolean
 
+  @DoNotStrip public fun enableAsyncDiskCacheCheckInMultiSourceImageAndroid(): Boolean
+
   @DoNotStrip public fun enableBridgelessArchitecture(): Boolean
 
   @DoNotStrip public fun enableCppPropsIteratorSetter(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.kt

@@ -22,9 +22,14 @@ import android.graphics.Shader.TileMode
 import android.graphics.drawable.Animatable
 import android.graphics.drawable.Drawable
 import android.net.Uri
+import com.facebook.common.internal.Supplier
 import com.facebook.common.references.CloseableReference
 import com.facebook.common.util.UriUtil
+import com.facebook.datasource.DataSource
+import com.facebook.datasource.FirstAvailableDataSourceSupplier
+import com.facebook.datasource.IncreasingQualityDataSourceSupplier
 import com.facebook.drawee.backends.pipeline.Fresco
+import com.facebook.drawee.backends.pipeline.PipelineDraweeController
 import com.facebook.drawee.controller.AbstractDraweeControllerBuilder
 import com.facebook.drawee.controller.ControllerListener
 import com.facebook.drawee.controller.ForwardingControllerListener
@@ -35,6 +40,7 @@ import com.facebook.drawee.generic.RoundingParams
 import com.facebook.drawee.view.GenericDraweeView
 import com.facebook.imagepipeline.bitmaps.PlatformBitmapFactory
 import com.facebook.imagepipeline.common.ResizeOptions
+import com.facebook.imagepipeline.common.RotationOptions
 import com.facebook.imagepipeline.core.DownsampleMode
 import com.facebook.imagepipeline.image.CloseableImage
 import com.facebook.imagepipeline.image.ImageInfo
@@ -50,6 +56,7 @@ import com.facebook.react.bridge.ReadableMap
 import com.facebook.react.common.annotations.UnstableReactNativeAPI
 import com.facebook.react.common.annotations.VisibleForTesting
 import com.facebook.react.common.build.ReactBuildConfig
+import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
 import com.facebook.react.internal.featureflags.ReactNativeNewArchitectureFeatureFlags
 import com.facebook.react.modules.fresco.ImageCacheControl
 import com.facebook.react.modules.fresco.ReactNetworkImageRequest
@@ -91,6 +98,7 @@ public class ReactImageView(
   private val sources: MutableList<ImageSource> = mutableListOf()
   internal var imageSource: ImageSource? = null
   private var cachedImageSource: ImageSource? = null
+  private var diskCacheProbeCandidates: List<ImageSource> = emptyList()
   private var defaultImageDrawable: Drawable? = null
   private var loadingImageDrawable: Drawable? = null
   private var overlayColor = 0
@@ -396,6 +404,10 @@ public class ReactImageView(
     }
 
     setSourceImage()
+    updateViewForSelectedSource()
+  }
+
+  private fun updateViewForSelectedSource() {
     val imageSourceSafe = this.imageSource ?: return
     val doResize = shouldResize(imageSourceSafe)
 
@@ -458,16 +470,16 @@ public class ReactImageView(
 
     val resizeOptions = if (doResize) resizeOptions else null
 
+    val imagePipeline = Fresco.getImagePipeline()
     if (cacheControl == ImageCacheControl.RELOAD) {
-      val imagePipeline = Fresco.getImagePipeline()
       imagePipeline.evictFromCache(uri)
     }
 
     val imageRequestBuilder =
         ImageRequestBuilder.newBuilderWithSource(uri)
             .setPostprocessor(postprocessor)
             .setResizeOptions(resizeOptions)
-            .setAutoRotateEnabled(true)
+            .setRotationOptions(RotationOptions.autoRotate())
             .setProgressiveRenderingEnabled(progressiveRenderingEnabled)
             .setLowestPermittedRequestLevel(requestLevel)
 
@@ -493,24 +505,101 @@ public class ReactImageView(
 
     // This builder is reused
     builder.reset()
+    builder.setDataSourceSupplier(null)
+
+    builder.setAutoPlayAnimations(true).setOldController(controller)
+
+    val cachedImageRequest =
+        cachedImageSource?.let { cachedSource ->
+          val cachedImageRequestBuilder =
+              ImageRequestBuilder.newBuilderWithSource(cachedSource.uri)
+                  .setPostprocessor(postprocessor)
+                  .setResizeOptions(resizeOptions)
+                  .setRotationOptions(RotationOptions.autoRotate())
+                  .setProgressiveRenderingEnabled(progressiveRenderingEnabled)
+          if (resizeMethod == ImageResizeMethod.NONE) {
+            cachedImageRequestBuilder.setDownsampleOverride(DownsampleMode.NEVER)
+          }
+          cachedImageRequestBuilder.build()
+        }
 
-    builder.setImageRequest(imageRequest).setAutoPlayAnimations(true).setOldController(controller)
-
-    callerContext?.let { builder.setCallerContext(it) }
-
-    cachedImageSource?.let { cachedSource ->
-      val cachedImageRequestBuilder =
-          ImageRequestBuilder.newBuilderWithSource(cachedSource.uri)
-              .setPostprocessor(postprocessor)
-              .setResizeOptions(resizeOptions)
-              .setAutoRotateEnabled(true)
-              .setProgressiveRenderingEnabled(progressiveRenderingEnabled)
-      if (resizeMethod == ImageResizeMethod.NONE) {
-        cachedImageRequestBuilder.setDownsampleOverride(DownsampleMode.NEVER)
+    if (diskCacheProbeCandidates.isEmpty()) {
+      builder.setImageRequest(imageRequest).setLowResImageRequest(cachedImageRequest)
+    } else {
+      val diskCacheRequests = ArrayList<ImageRequest>(diskCacheProbeCandidates.size)
+      for (source in diskCacheProbeCandidates) {
+        val diskCacheRequestBuilder =
+            ImageRequestBuilder.newBuilderWithSource(source.uri)
+                .setPostprocessor(postprocessor)
+                .setResizeOptions(resizeOptions)
+                .setRotationOptions(RotationOptions.autoRotate())
+                .setProgressiveRenderingEnabled(progressiveRenderingEnabled)
+                .setLowestPermittedRequestLevel(RequestLevel.DISK_CACHE)
+        if (resizeMethod == ImageResizeMethod.NONE) {
+          diskCacheRequestBuilder.setDownsampleOverride(DownsampleMode.NEVER)
+        }
+        diskCacheRequests.add(
+            ReactNetworkImageRequest.fromBuilderWithHeaders(
+                diskCacheRequestBuilder,
+                headers,
+                source.cacheControl,
+            ),
+        )
       }
-      builder.setLowResImageRequest(cachedImageRequestBuilder.build())
+      val requestCallerContext = callerContext
+      builder.setDataSourceSupplier(
+          Supplier {
+            val pipelineController = controller as? PipelineDraweeController
+            val requestListener = pipelineController?.requestListener
+            val controllerId = pipelineController?.id
+            fun dataSourceSupplierFor(request: ImageRequest, level: RequestLevel) =
+                imagePipeline.getDataSourceSupplier(
+                    request,
+                    requestCallerContext,
+                    level,
+                    requestListener,
+                    controllerId,
+                )
+
+            val diskCacheDataSourceSuppliers =
+                ArrayList<
+                    Supplier<DataSource<CloseableReference<CloseableImage>>>,
+                >(
+                    diskCacheRequests.size,
+                )
+            for (request in diskCacheRequests) {
+              diskCacheDataSourceSuppliers.add(
+                  dataSourceSupplierFor(request, RequestLevel.FULL_FETCH),
+              )
+            }
+            val diskCacheDataSourceSupplier =
+                FirstAvailableDataSourceSupplier.create(diskCacheDataSourceSuppliers)
+            val lowerResDataSourceSupplier =
+                cachedImageRequest?.let { memoryCacheRequest ->
+                  IncreasingQualityDataSourceSupplier.create(
+                      arrayListOf(
+                          diskCacheDataSourceSupplier,
+                          dataSourceSupplierFor(
+                              memoryCacheRequest,
+                              RequestLevel.BITMAP_MEMORY_CACHE,
+                          ),
+                      ),
+                      imagePipeline.isLazyDataSource.get(),
+                  )
+                } ?: diskCacheDataSourceSupplier
+            val highResDataSourceSupplier =
+                dataSourceSupplierFor(imageRequest, RequestLevel.FULL_FETCH)
+            IncreasingQualityDataSourceSupplier.create(
+                    arrayListOf(highResDataSourceSupplier, lowerResDataSourceSupplier),
+                    imagePipeline.isLazyDataSource.get(),
+                )
+                .get()
+          },
+      )
     }
 
+    callerContext?.let { builder.setCallerContext(it) }
+
     if (downloadListener != null && controllerForTesting != null) {
       val combinedListener: ForwardingControllerListener<ImageInfo> =
           ForwardingControllerListener<ImageInfo>()
@@ -531,6 +620,7 @@ public class ReactImageView(
 
     // Reset again so the DraweeControllerBuilder clears all it's references. Otherwise, this causes
     // a memory leak.
+    builder.setDataSourceSupplier(null)
     builder.reset()
   }
 
@@ -556,12 +646,24 @@ public class ReactImageView(
 
   private fun setSourceImage() {
     imageSource = null
+    cachedImageSource = null
+    diskCacheProbeCandidates = emptyList()
     if (sources.isEmpty()) {
       sources.add(getTransparentBitmapImageSource(context))
     } else if (hasMultipleSources()) {
-      val multiSource = getBestSourceForSize(width, height, sources)
+      val asyncDiskCacheCheckEnabled =
+          ReactNativeFeatureFlags.enableAsyncDiskCacheCheckInMultiSourceImageAndroid()
+      val multiSource =
+          getBestSourceForSize(
+              width,
+              height,
+              sources,
+              1.0,
+              checkDiskCache = !asyncDiskCacheCheckEnabled,
+          )
       imageSource = multiSource.bestResult
       cachedImageSource = multiSource.bestResultInCache
+      diskCacheProbeCandidates = multiSource.diskCacheProbeCandidates
       return
     }
     imageSource = sources[0]