Read plugin framework names that contain a space; fix Flow variance syntax

Author: chrfalch

packages/react-native/scripts/spm/__tests__/plugin-framework-mismatch-test.js

@@ -206,6 +206,15 @@ describe('assertPluginFrameworksLinked', () => {
     expect(check(app)).toEqual({error: null, lines: []});
   });
 
+  it('reads framework names that contain a space', () => {
+    const app = scaffoldApp();
+    const spaced = frameworkEntry('my-fw', 'My Fw', 'My Fw.xcframework');
+    inject(app, [REACT, HERMES, spaced]);
+    writeSidecar(app.appRoot, [spaced]);
+
+    expect(check(app)).toEqual({error: null, lines: []});
+  });
+
   it('compares only setting prefixes when the frameworks manifest is missing', () => {
     const app = scaffoldApp();
     inject(app, [REACT, HERMES, EXPO]);

packages/react-native/scripts/spm/generate-spm-xcodeproj.js

@@ -2283,7 +2283,7 @@ class PluginFrameworkMismatchError extends Error {
  */
 function assertPluginFrameworksLinked(
   appRoot /*: string */,
-  env /*: {+[string]: ?string} */ = process.env,
+  env /*: {readonly [string]: ?string} */ = process.env,
 ) /*: void */ {
   const builtProjectPath = env.PROJECT_FILE_PATH;
   const xcodeprojPath =
@@ -2336,7 +2336,7 @@ function assertPluginFrameworksLinked(
     );
     linkedPluginNames = new Set(
       Array.from(
-        outputs.matchAll(/([^/"\s]+)\.framework\b/g),
+        outputs.matchAll(/([^/"\n]+)\.framework\b/g),
         m => m[1],
       ).filter(name => !builtinNames.has(name)),
     );