Skip to content

Commit f29ca4c

Browse files
conner1reimersconner1reimers
committed
Restore ReactTextView.setMinimumFontSize() as deprecated and add setMinimumFontScale()
1 parent 9c12869 commit f29ca4c

5 files changed

Lines changed: 60 additions & 7 deletions

File tree

‎packages/react-native/ReactAndroid/api/ReactAndroid.api‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6035,6 +6035,7 @@ public class com/facebook/react/views/text/ReactTextView : androidx/appcompat/wi
60356035
public fun setLetterSpacing (F)V
60366036
public fun setLinkifyMask (I)V
60376037
public fun setMinimumFontScale (F)V
6038+
public fun setMinimumFontSize (F)V
60386039
public fun setNumberOfLines (I)V
60396040
public fun setOverflow (Ljava/lang/String;)V
60406041
public fun setSpanned (Landroid/text/Spannable;)V

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
7171
private @Nullable TextUtils.TruncateAt mEllipsizeLocation;
7272
private boolean mAdjustsFontSizeToFit;
7373
private float mFontSize;
74+
private float mMinimumFontSize;
7475
private float mMinimumFontScale;
7576
private float mLetterSpacing;
7677
private int mLinkifyMaskType;
@@ -132,6 +133,7 @@ private void initView() {
132133
mShouldAdjustSpannableFontSize = false;
133134
mEllipsizeLocation = TextUtils.TruncateAt.END;
134135
mFontSize = Float.NaN;
136+
mMinimumFontSize = Float.NaN;
135137
mMinimumFontScale = Float.NaN;
136138
mLetterSpacing = 0.f;
137139
mOverflow = Overflow.VISIBLE;
@@ -238,6 +240,7 @@ protected void onDraw(Canvas canvas) {
238240
YogaMeasureMode.EXACTLY,
239241
getHeight(),
240242
YogaMeasureMode.EXACTLY,
243+
mMinimumFontSize,
241244
mMinimumFontScale,
242245
mNumberOfLines,
243246
getIncludeFontPadding(),
@@ -540,6 +543,15 @@ public void setFontSize(float fontSize) {
540543
applyTextAttributes();
541544
}
542545

546+
/**
547+
* @deprecated Use {@link #setMinimumFontScale(float)} instead.
548+
*/
549+
@Deprecated
550+
public void setMinimumFontSize(float minimumFontSize) {
551+
mMinimumFontSize = minimumFontSize;
552+
mShouldAdjustSpannableFontSize = true;
553+
}
554+
543555
public void setMinimumFontScale(float minimumFontScale) {
544556
mMinimumFontScale = minimumFontScale;
545557
mShouldAdjustSpannableFontSize = true;

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.kt‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,13 @@ public constructor(
168168
)
169169
view.setSpanned(spanned)
170170

171+
val minimumFontSize: Float =
172+
paragraphAttributes.getDouble(TextLayoutManager.PA_KEY_MINIMUM_FONT_SIZE).toFloat()
173+
@Suppress("DEPRECATION") view.setMinimumFontSize(minimumFontSize)
171174
val minimumFontScale: Float =
172-
paragraphAttributes.getDouble(TextLayoutManager.PA_KEY_MINIMUM_FONT_SCALE).toFloat()
175+
if (paragraphAttributes.contains(TextLayoutManager.PA_KEY_MINIMUM_FONT_SCALE))
176+
paragraphAttributes.getDouble(TextLayoutManager.PA_KEY_MINIMUM_FONT_SCALE).toFloat()
177+
else Float.NaN
173178
view.setMinimumFontScale(minimumFontScale)
174179

175180
// Clear any stale PreparedLayout from a previous update

‎packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.kt‎

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,10 @@ internal object TextLayoutManager {
9393
const val PA_KEY_ADJUST_FONT_SIZE_TO_FIT: Int = 3
9494
const val PA_KEY_INCLUDE_FONT_PADDING: Int = 4
9595
const val PA_KEY_HYPHENATION_FREQUENCY: Int = 5
96-
const val PA_KEY_MINIMUM_FONT_SCALE: Int = 6
96+
const val PA_KEY_MINIMUM_FONT_SIZE: Int = 6
9797
const val PA_KEY_TEXT_ALIGN_VERTICAL: Int = 8
9898
const val PA_KEY_TEXT_WIDTH_MODE: Int = 9
99+
const val PA_KEY_MINIMUM_FONT_SCALE: Int = 10
99100

100101
private val TAG: String = TextLayoutManager::class.java.simpleName
101102

@@ -1049,6 +1050,10 @@ internal object TextLayoutManager {
10491050
val justificationMode = getTextJustificationMode(alignmentAttr)
10501051

10511052
if (adjustFontSizeToFit) {
1053+
val minimumFontSize =
1054+
if (paragraphAttributes.contains(PA_KEY_MINIMUM_FONT_SIZE))
1055+
paragraphAttributes.getDouble(PA_KEY_MINIMUM_FONT_SIZE).toFloat()
1056+
else Float.NaN
10521057
val minimumFontScale =
10531058
if (paragraphAttributes.contains(PA_KEY_MINIMUM_FONT_SCALE))
10541059
paragraphAttributes.getDouble(PA_KEY_MINIMUM_FONT_SCALE).toFloat()
@@ -1060,6 +1065,7 @@ internal object TextLayoutManager {
10601065
YogaMeasureMode.EXACTLY,
10611066
height,
10621067
heightYogaMeasureMode,
1068+
minimumFontSize,
10631069
minimumFontScale,
10641070
maximumNumberOfLines,
10651071
includeFontPadding,
@@ -1218,6 +1224,7 @@ internal object TextLayoutManager {
12181224
widthYogaMeasureMode: YogaMeasureMode,
12191225
height: Float,
12201226
heightYogaMeasureMode: YogaMeasureMode,
1227+
minimumFontSizeAttr: Float,
12211228
minimumFontScale: Float,
12221229
maximumNumberOfLines: Int,
12231230
includeFontPadding: Boolean,
@@ -1237,12 +1244,16 @@ internal object TextLayoutManager {
12371244
currentFontSize = max(currentFontSize, span.size)
12381245
}
12391246

1240-
// The smallest font size is the largest font size scaled by minimumFontScale, floored at 4dp
1241-
// to match the iOS implementation.
1247+
// An explicit minimum font size wins over minimumFontScale, which is applied to the largest
1248+
// font size in the spannable. The 4dp floor matches the iOS implementation.
12421249
val absoluteMinimumFontSize = 4.dpToPx().toInt()
12431250
val minimumFontSize =
1244-
if (minimumFontScale.isNaN() || minimumFontScale <= 0f) absoluteMinimumFontSize
1245-
else max((minimumFontScale * currentFontSize).toInt(), absoluteMinimumFontSize)
1251+
when {
1252+
!minimumFontSizeAttr.isNaN() -> minimumFontSizeAttr.toInt()
1253+
!minimumFontScale.isNaN() && minimumFontScale > 0f ->
1254+
max((minimumFontScale * currentFontSize).toInt(), absoluteMinimumFontSize)
1255+
else -> absoluteMinimumFontSize
1256+
}
12461257
currentFontSize = max(currentFontSize, minimumFontSize)
12471258

12481259
var intervalStart = minimumFontSize

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/TextLayoutManagerMinimumFontScaleTest.kt‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,24 @@ class TextLayoutManagerMinimumFontScaleTest {
8989
assertThat(largestFontSize(text)).isEqualTo(4.dpToPx().toInt())
9090
}
9191

92+
@Test
93+
fun `explicit minimumFontSize is used as the floor`() {
94+
val text = spannableWithFontSize(LARGE_FONT_SIZE)
95+
96+
adjustToUnsatisfiableHeight(text, minimumFontSize = 12f, minimumFontScale = Float.NaN)
97+
98+
assertThat(largestFontSize(text)).isEqualTo(12)
99+
}
100+
101+
@Test
102+
fun `explicit minimumFontSize takes precedence over minimumFontScale`() {
103+
val text = spannableWithFontSize(LARGE_FONT_SIZE)
104+
105+
adjustToUnsatisfiableHeight(text, minimumFontSize = 12f, minimumFontScale = 0.5f)
106+
107+
assertThat(largestFontSize(text)).isEqualTo(12)
108+
}
109+
92110
@Test
93111
fun `text that already fits is not shrunk`() {
94112
val text = spannableWithFontSize(LARGE_FONT_SIZE)
@@ -99,6 +117,7 @@ class TextLayoutManagerMinimumFontScaleTest {
99117
YogaMeasureMode.EXACTLY,
100118
10_000f,
101119
YogaMeasureMode.EXACTLY,
120+
Float.NaN,
102121
0.5f,
103122
ReactConstants.UNSET,
104123
true,
@@ -113,13 +132,18 @@ class TextLayoutManagerMinimumFontScaleTest {
113132
}
114133

115134
// Uses a height no font size can satisfy so the text is shrunk all the way to the minimum.
116-
private fun adjustToUnsatisfiableHeight(text: SpannableString, minimumFontScale: Float) {
135+
private fun adjustToUnsatisfiableHeight(
136+
text: SpannableString,
137+
minimumFontScale: Float,
138+
minimumFontSize: Float = Float.NaN,
139+
) {
117140
TextLayoutManager.adjustSpannableFontToFit(
118141
text,
119142
10_000f,
120143
YogaMeasureMode.EXACTLY,
121144
1f,
122145
YogaMeasureMode.EXACTLY,
146+
minimumFontSize,
123147
minimumFontScale,
124148
ReactConstants.UNSET,
125149
true,

0 commit comments

Comments
 (0)