Skip to content

Commit f82830d

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Use a variable for the Maestro Cloud project ID (#58408)
Summary: Read the Maestro Cloud project ID from a GitHub Actions variable instead of a secret. Project IDs are identifiers rather than credentials, and secret masking currently redacts the project ID inside Maestro Cloud console URLs, making those links invalid. The API key remains a secret. The `MAESTRO_CLOUD_PROJECT_ID` repository variable has already been configured. ## Changelog: [INTERNAL] [FIXED] - Preserve Maestro Cloud console URLs in GitHub Actions logs Pull Request resolved: #58408 Test Plan: - `git diff --check` — passed - `./node_modules/.bin/prettier --check .github/workflows/maestro-cloud-rntester.yml` — passed - Verified `MAESTRO_CLOUD_PROJECT_ID` is available as a repository Actions variable Reviewed By: cipolleschi Differential Revision: D119322826 Pulled By: cortinico fbshipit-source-id: fc26750a93e7b421a891d496f2e2e66f8868410c
1 parent 5d84f62 commit f82830d

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

‎.github/workflows/maestro-cloud-rntester.yml‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ on:
3333
secrets:
3434
MAESTRO_CLOUD_API_KEY:
3535
required: true
36-
MAESTRO_CLOUD_PROJECT_ID:
37-
required: true
3836

3937
jobs:
4038
test:
@@ -55,7 +53,7 @@ jobs:
5553
env:
5654
MAESTRO_APP_FILE: ${{ inputs.app-file }}
5755
MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
58-
MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
56+
MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
5957
run: |
6058
test -e "$MAESTRO_APP_FILE"
6159
test -n "$MAESTRO_CLOUD_API_KEY"
@@ -65,7 +63,7 @@ jobs:
6563
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
6664
with:
6765
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
68-
project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
66+
project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
6967
app-file: ${{ inputs.app-file }}
7068
workspace: packages/rn-tester/.maestro
7169
branch: ${{ github.head_ref || github.ref_name }}

0 commit comments

Comments
 (0)