Fix iOS removeClippedSubviews being lost on recycled views (#58915)

Summary:
On iOS, `prepareForRecycle` resets `_removeClippedSubviews` to `NO` but keeps `_props`, and `updateProps:oldProps:` only set the flag when `removeClippedSubviews` differed from `_props`. So a recycled view whose previous props also had `removeClippedSubviews` never turned clipping back on, and a remounted `ScrollView`/`FlatList` kept every row attached. This compares against `_removeClippedSubviews` itself, and adds a test.

Fixes #58914. Repro: https://github.com/mozzius/view-remove-clipped-subviews-recycle-repro

## Changelog:

[IOS] [FIXED] - removeClippedSubviews is kept on recycled views

Pull Request resolved: #58915

Test Plan:
In the repro (a `ScrollView` with `removeClippedSubviews` and 100 rows, unmounted and mounted again), the recycled content view keeps all 100/100 rows attached on every remount without this change (7/7, including 3/3 on unmodified 0.87.1), and 7/100 with it (3/3), the same as on first mount. The new `RCTViewComponentViewTests` case, run inside the repro app against 0.87.1 built from source, fails without the change and passes with it.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Reviewed By: sammy-SC

Differential Revision: D123878627

Pulled By: cipolleschi

fbshipit-source-id: 21d792698d74805f61a9a93f5b944d8f5abcd7f3

Author: mozzius

packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm

@@ -359,7 +359,9 @@ - (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &
 
   // Disable `removeClippedSubviews` when Fabric View Culling is enabled.
   if (!ReactNativeFeatureFlags::enableViewCulling()) {
-    if (oldViewProps.removeClippedSubviews != newViewProps.removeClippedSubviews) {
+    // Compare against the current state, not `_props`: `prepareForRecycle` resets
+    // `_removeClippedSubviews` but keeps `_props`.
+    if (_removeClippedSubviews != newViewProps.removeClippedSubviews) {
       _removeClippedSubviews = newViewProps.removeClippedSubviews;
       [self _updateRemoveClippedSubviewsState];
     }

packages/react-native/React/Tests/Mounting/RCTViewComponentViewTests.mm

@@ -143,6 +143,26 @@ - (void)testUnmountAfterToggleOffCleansUpReactSubviews
   XCTAssertNil(child2.superview);
 }
 
+- (void)testRemoveClippedSubviewsIsKeptOnRecycledView
+{
+  RCTViewComponentView *view = [RCTViewComponentView new];
+  [view updateProps:makeViewProps(true) oldProps:ViewShadowNode::defaultSharedProps()];
+  [view prepareForRecycle];
+
+  // Reused for another view with removeClippedSubviews. Like the mounting layer
+  // does for an Insert, pass no old props: the view diffs against its own.
+  [view updateProps:makeViewProps(true) oldProps:nullptr];
+
+  UIView *child = [UIView new];
+  child.frame = CGRectMake(0, 400, 50, 50);
+  [view mountChildComponentView:(id)child index:0];
+
+  // Clipping is on, so the child is tracked and left for the clipping pass to attach.
+  XCTAssertNil(child.superview);
+  NSMutableArray *reactSubviews = [view valueForKey:@"_reactSubviews"];
+  XCTAssertEqual(reactSubviews.count, 1u);
+}
+
 #pragma mark - hitTest against non-invertible transforms (#50797)
 
 - (void)testHitTestReturnsNilForZeroScaleYView