Repository navigation
Conversation
Add Kotlin collection factory functions for maps(WritableMap, ReadableMap) and arrays(WritableArray, ReadableArray) Introduce idiomatic Kotlin factory functions for creating React Native bridge collection types: - `writableMapOf()`: Creates WritableMap with vararg key-value pairs - `writableArrayOf()`: Creates WritableArray with vararg elements - `readableMapOf()`: Returns ReadableMap - `readableArrayOf()`: Returns ReadableArray These functions mirror Kotlin's standard library conventions (mapOf/mutableMapOf) and provide a more concise alternative to the builder DSL pattern when constructing small, static collections. Supported types: null, Boolean, Int, Long, Float, Double, String, ReadableMap, ReadableArray. Long and Float are converted to Double for JavaScript compatibility.
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
Author
|
@cortinico Hello! Can you review this PR? This PR's goal is same as previous one. |
cortinico
requested changes
Feb 10, 2026
| * | ||
| * @throws IllegalArgumentException if a value is of unsupported type | ||
| */ | ||
| public fun writableMapOf(vararg pairs: Pair<String, Any?>): WritableMap { |
Contributor
There was a problem hiding this comment.
Similar to 78dbbaa you should put those inside WritableArrayBuilder and so on
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is based on the proposal: react-native-community/discussions-and-proposals#966
Add Kotlin collection factory functions for maps (WritableMap, ReadableMap) and arrays (WritableArray, ReadableArray)
Introduce idiomatic Kotlin factory functions for creating React Native bridge collection types:
writableMapOf(): Creates WritableMap with vararg key-value pairswritableArrayOf(): Creates WritableArray with vararg elementsreadableMapOf(): Returns ReadableMapreadableArrayOf(): Returns ReadableArrayThese functions mirror Kotlin's standard library conventions (mapOf/mutableMapOf) and provide a more concise alternative to the builder DSL pattern when constructing small, static collections.
Supported types: null, Boolean, Int, Long, Float, Double, String, ReadableMap, ReadableArray.
Changelog:
[ANDROID] [ADDED] - Add Kotlin collection factory functions: writableMapOf, writableArrayOf, readableMapOf, readableArrayOf
Test Plan:
Unit tests added in
CollectionFactoryTest.ktcovering: