Repository navigation
Conversation
Summary: The for-frameworks guard skipped its warning whenever `RN_UMBRELLA_CONTEXT` was defined, and its message told consumers to include the header through the module umbrella. Neither makes sense for this tier: umbrellas only re-export public headers, and framework-tier modules have no umbrella at all. The exemption therefore had no legitimate use; its only effect was to hide a public header transitively leaking a for-frameworks header into consumer code. Drop the `RN_UMBRELLA_CONTEXT` exemption so such a leak is reported, and point the message at the only real escape hatch, `RN_ALLOW_FRAMEWORKS`. No umbrella or public header includes a for-frameworks header today, so this does not change any existing build. Changelog: [Internal] Differential Revision: D123399815
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123399815. |
|
This pull request has been merged in 2afaf3b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The for-frameworks guard skipped its warning whenever
RN_UMBRELLA_CONTEXTwas defined, and its message told consumers to include the header through the module umbrella. Neither makes sense for this tier: umbrellas only re-export public headers, and framework-tier modules have no umbrella at all. The exemption therefore had no legitimate use; its only effect was to hide a public header transitively leaking a for-frameworks header into consumer code.Drop the
RN_UMBRELLA_CONTEXTexemption so such a leak is reported, and point the message at the only real escape hatch,RN_ALLOW_FRAMEWORKS. No umbrella or public header includes a for-frameworks header today, so this does not change any existing build.Changelog:
[Internal]
Differential Revision: D123399815