refactor: make resetToPackagedBundle silent by default, returning boolean

Align with the other update-flow APIs (checkUpdate/downloadUpdate):
never throw by default — failures resolve to false with the
RESET_FAILED error surfaced via lastError/onError, and throwError
opts back into throwing. Callers must check the return value: false
means the app is still running the hot-updated bundle.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: sunnylqm

Example/e2etest/src/index.tsx

@@ -109,13 +109,9 @@ function App() {
           style={styles.button}
           onPress={async () => {
             setLastEvent('triggerReset');
-            try {
-              await resetToPackagedBundle({ restart: false });
-              setLastEvent('resetDone');
-            } catch (e) {
-              setLastEvent('resetFailed');
-              setLastEventData(e instanceof Error ? e.message : String(e));
-            }
+            // 静默失败语义:失败不抛错而是返回 false,错误进 lastError
+            const ok = await resetToPackagedBundle({ restart: false });
+            setLastEvent(ok ? 'resetDone' : 'resetFailed');
           }}
         >
           <Text style={styles.buttonText}>Reset</Text>

src/__tests__/client.test.ts

@@ -983,8 +983,9 @@ describe('resetToPackagedBundle', () => {
     sharedState.marked = true;
     const client = new Pushy({ appKey: 'demo-app' });
 
-    await client.resetToPackagedBundle();
+    const result = await client.resetToPackagedBundle();
 
+    expect(result).toBe(true);
     expect(resetToPackagedBundle).toHaveBeenCalledTimes(1);
     expect(sharedState.downloadedHash).toBeUndefined();
     expect(sharedState.marked).toBe(false);
@@ -1005,30 +1006,48 @@ describe('resetToPackagedBundle', () => {
     expect(restartApp).toHaveBeenCalledTimes(1);
   });
 
-  test('throws RESET_FAILED when the native module lacks the method', async () => {
-    // Simulates new JS arriving via hot update onto an older binary.
+  test('resolves false with RESET_FAILED via onError when the native module lacks the method', async () => {
+    // Simulates new JS arriving via hot update onto an older binary. Like the
+    // other update-flow APIs this must not throw by default.
     setupClientMocks({ resetToPackagedBundle: null });
     const { Pushy } = await importFreshClient('reset-unsupported');
     const client = new Pushy({ appKey: 'demo-app' });
+    const seen: any[] = [];
+    client.onError((err: any) => seen.push(err));
+
+    const result = await client.resetToPackagedBundle();
+
+    expect(result).toBe(false);
+    expect(seen).toHaveLength(1);
+    expect(seen[0].code).toBe('RESET_FAILED');
+  });
+
+  test('throwError option makes an unsupported reset throw', async () => {
+    setupClientMocks({ resetToPackagedBundle: null });
+    const { Pushy } = await importFreshClient('reset-unsupported-throw');
+    const client = new Pushy({ appKey: 'demo-app', throwError: true });
 
     await expect(client.resetToPackagedBundle()).rejects.toMatchObject({
       code: 'RESET_FAILED',
     });
   });
 
-  test('propagates native failures with the RESET_FAILED code and keeps state', async () => {
+  test('resolves false on native failure and keeps state', async () => {
     const resetToPackagedBundle = mock(() =>
       Promise.reject(Error('disk full')),
     );
     setupClientMocks({ resetToPackagedBundle });
     const { Pushy, sharedState } = await importFreshClient('reset-native-fail');
     sharedState.downloadedHash = 'stale-hash';
     const client = new Pushy({ appKey: 'demo-app' });
+    const seen: any[] = [];
+    client.onError((err: any) => seen.push(err));
 
-    await expect(client.resetToPackagedBundle()).rejects.toMatchObject({
-      code: 'RESET_FAILED',
-      message: 'disk full',
-    });
+    const result = await client.resetToPackagedBundle();
+
+    expect(result).toBe(false);
+    expect(seen[0].code).toBe('RESET_FAILED');
+    expect(seen[0].message).toBe('disk full');
     // The native reset did not happen, so the bookkeeping must not be wiped.
     expect(sharedState.downloadedHash).toBe('stale-hash');
   });

src/client.ts

@@ -956,34 +956,43 @@ export class Pushy {
    * and the whole update state on the native side, so the app loads the
    * built-in bundle on the next launch (or immediately with
    * `{ restart: true }`). The client uuid is preserved.
+   *
+   * Returns whether the reset actually happened. Like the other update-flow
+   * APIs it never throws by default — failures land in lastError/onError with
+   * code RESET_FAILED — but the boolean must not be ignored: a false means the
+   * app is still running the hot-updated bundle. Set `throwError` to throw.
    */
-  resetToPackagedBundle = async (options?: { restart?: boolean }) => {
+  resetToPackagedBundle = async (options?: {
+    restart?: boolean;
+  }): Promise<boolean> => {
     if (typeof PushyModule.resetToPackagedBundle !== 'function') {
       // The JS layer can arrive via hot update onto an older binary whose
-      // native module predates this method; fail loudly instead of pretending
-      // the reset happened.
+      // native module predates this method.
       const err = new UpdateError(
         this.t('error_reset_not_supported'),
         'RESET_FAILED',
       );
       this.emitError(err, 'errorReset');
-      throw err;
+      this.throwIfEnabled(err);
+      return false;
     }
     try {
       await PushyModule.resetToPackagedBundle();
     } catch (e) {
       const err = toUpdateError(e, 'RESET_FAILED');
       this.emitError(err, 'errorReset');
-      throw err;
+      this.throwIfEnabled(err);
+      return false;
     }
     // The downloaded versions are gone; drop JS bookkeeping referring to them
     // so a stale downloadedHash cannot be switched to.
     sharedState.downloadedHash = undefined;
     sharedState.marked = false;
     this.report({ type: 'reset' });
     if (options?.restart) {
-      return this.restartApp();
+      await this.restartApp();
     }
+    return true;
   };
 }
 

src/context.ts

@@ -44,7 +44,9 @@ export const UpdateContext = createContext<{
   } | null;
   parseTestQrCode: (code: string) => boolean;
   restartApp: () => Promise<void>;
-  resetToPackagedBundle: (options?: { restart?: boolean }) => Promise<void>;
+  resetToPackagedBundle: (options?: {
+    restart?: boolean;
+  }) => Promise<boolean | void>;
   currentHash: string;
   packageVersion: string;
   client?: Pushy | Cresc;