Scorecard: Assert correctness of threshold constants in unit tests

[christoph-jerolimov]

Invalid threshold definitions let the scorecard plugin fail to start. For the ThresholdConfigs in the code base, unit tests should assert their correctness.

Add a unit tests that calls validateThresholdNumberIntervals for each of this ThresholdConfigs:

1. PERCENTAGE_THRESHOLDS in @plugins/scorecard-backend-module-code-coverage/src/metricProviders/CodeCoverageMetricProvider.ts
2. DEPENDABOT_THRESHOLDS in @plugins/scorecard-backend-module-dependabot/src/metricProviders/DependabotConfig.ts
3. OPENSSF_THRESHOLDS in @plugins/scorecard-backend-module-openssf/src/metricProviders/OpenSSFConfig.ts
4. SONARQUBE_NUMBER_THRESHOLDS in @plugins/scorecard-backend-module-sonarqube/src/metricProviders/SonarQubeConfig.ts
5. DEFAULT_NUMBER_THRESHOLDS in @plugins/scorecard-common/src/types/threshold.ts

The test just need to pass without an exception.

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 10:16 PM UTC · Completed 10:20 PM UTC

Commit: 9b57fa7 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.05

[fullsend-ai-triage]

Proposed test case

For each of the 5 threshold constants, add a test that asserts validateThresholdNumberIntervals does not throw:

import { validateThresholdNumberIntervals } from '@red-hat-developer-hub/backstage-plugin-scorecard-node';
import { PERCENTAGE_THRESHOLDS } from './CodeCoverageMetricProvider';

describe('CodeCoverageMetricProvider thresholds', () => {
  it('PERCENTAGE_THRESHOLDS has valid number intervals', () => {
    expect(() =>
      validateThresholdNumberIntervals(PERCENTAGE_THRESHOLDS.rules, 'number'),
    ).not.toThrow();
  });
});

Tests can be placed alongside existing test files in each module's metricProviders/ directory (or in scorecard-common/src/types/ for DEFAULT_NUMBER_THRESHOLDS). This is a no-changeset task since it adds only internal tests with no user-facing behavior change.

---

Labels: Scorecard workspace test addition — workspace/scorecard scopes the workspace and Tests categorizes the work type.

---

Next steps:

• /fs-code — agent creates a PR to implement this issue
• /fs-code <your instruction> — agent implements with your specific guidance

[christoph-jerolimov]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 6:31 AM UTC · Completed 6:47 AM UTC

Commit: 9b57fa7 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $2.54