Skip to content

Commit ba55dc9

Browse files
committed
tensordict: carry forward riscv64 patches to 0.14.3
Nightly version bump omitted the patches/tensordict/<version> directory for 0.14.3, so the build's unconditional `git apply .../*.patch` step failed with "No such file or directory" before any build/test ran. Copied forward the same patch set from 0.14.2 (unchanged since then).
1 parent 2ccb37d commit ba55dc9

1 file changed

Lines changed: 32 additions & 0 deletions

File tree

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
From 3f9f69dd229764f224841c70f2a8f071ff29f7d3 Mon Sep 17 00:00:00 2001
2+
From: Ludovic Henry <git@ludovic.dev>
3+
Date: Sun, 13 Sep 2026 00:49:14 +0200
4+
Subject: [PATCH] csrc: request only Development.Module from FindPython3
5+
6+
CMakeLists.txt asks FindPython3 for the full Development component, which
7+
requires both Development.Module and Development.Embed (a libpython usable
8+
for embedding). manylinux wheel-building images build CPython with
9+
Py_ENABLE_SHARED=0 and ship only a static libpython, so Development.Embed's
10+
Python3_LIBRARIES lookup fails and configure aborts, even though building a
11+
plain extension module only ever needs Development.Module. Reproduces the
12+
same way on manylinux x86_64/aarch64, not just riscv64 (confirmed locally
13+
against quay.io/pypa/manylinux_2_39_aarch64).
14+
15+
Upstream-Status: To upstream [not yet submitted; this repo does not open issues/PRs on third-party repositories]
16+
---
17+
tensordict/csrc/CMakeLists.txt | 2 +-
18+
1 file changed, 1 insertion(+), 1 deletion(-)
19+
20+
diff --git a/tensordict/csrc/CMakeLists.txt b/tensordict/csrc/CMakeLists.txt
21+
index 85b5519d..df3a426e 100644
22+
--- a/tensordict/csrc/CMakeLists.txt
23+
+++ b/tensordict/csrc/CMakeLists.txt
24+
@@ -10,7 +10,7 @@ if(APPLE) # Check if the target OS is OSX/macOS
25+
include(FindPythonPyEnv)
26+
endif()
27+
28+
-find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
29+
+find_package(Python3 REQUIRED COMPONENTS Interpreter Development.Module)
30+
find_package(pybind11 2.13 REQUIRED)
31+
32+
file(GLOB SOURCES "*.cpp")

0 commit comments

Comments
 (0)