Skip to content

Commit d2204ef

Browse files
committed
lancedb: ignore test_first_class_function_slice1/2.py, sandbox-incompatible
Both files were added in 0.38.0/0.39.0 and read golden fixtures (docs/src/python/python.md, rust/lancedb/tests/fixtures/first_class_functions/v1/*.json) that live outside the CIBW_TEST_SOURCES tree (only pyproject.toml and python/tests are copied into the isolated cibuildwheel test dir), so every test in both files fails with FileNotFoundError regardless of platform -- 23/23 failures on both 0.38.0 and 0.39.0. Same class of trap as the existing test_pyo3_abi_matches_minimum_supported_python deselect: a source-tree/golden-contract check, not installed-wheel runtime behavior.
1 parent e8c0c42 commit d2204ef

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

‎.github/workflows/build-lancedb.yml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,19 @@ jobs:
206206
# identically either way) and the tests run and fail anyway, as seen
207207
# in CI run 33843581031. `cd python` first puts pyproject.toml back
208208
# in the search path so --deselect (and the -m marker filter) work.
209+
#
210+
# test_first_class_function_slice1.py/slice2.py are new (0.38.0/
211+
# 0.39.0) and hit the exact same class of trap as
212+
# test_pyo3_abi_matches_minimum_supported_python above: they read
213+
# golden fixtures from outside the CIBW_TEST_SOURCES tree --
214+
# docs/src/python/python.md and rust/lancedb/tests/fixtures/
215+
# first_class_functions/v1/*.json, both siblings of python/ in the
216+
# full checkout but not copied into the isolated test dir (only
217+
# pyproject.toml and python/tests are) -- and fail with the same
218+
# FileNotFoundError regardless of platform. They assert Python/Rust
219+
# golden-contract and docs consistency, not installed-wheel runtime
220+
# behavior, so ignore both files rather than widen
221+
# CIBW_TEST_SOURCES to mirror docs/ and rust/'s layout.
209222
CIBW_TEST_COMMAND: >-
210223
cd python &&
211224
python -m pytest python/tests -vv --durations=30
@@ -216,6 +229,8 @@ jobs:
216229
--ignore=python/tests/test_namespace_integration.py
217230
--ignore=python/tests/docs/test_guide_tables.py
218231
--ignore=python/tests/docs/test_python.py
232+
--ignore=python/tests/test_first_class_function_slice1.py
233+
--ignore=python/tests/test_first_class_function_slice2.py
219234
--deselect=python/tests/test_db.py::test_create_table_stable_row_ids_via_storage_options
220235
--deselect=python/tests/test_db.py::test_create_table_stable_row_ids_via_storage_options_sync
221236
--deselect=python/tests/test_db.py::test_create_table_stable_row_ids_table_level_override

0 commit comments

Comments
 (0)