-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
x test should support --show-output #134210
Copy link
Copy link
Open
Labels
A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.Call for participation: Hard difficulty. Experience needed to fix: A lot.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Metadata
Metadata
Assignees
Labels
A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)Area: test infrastructure (may span bootstrap/compiletest/more)C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.E-hardCall for participation: Hard difficulty. Experience needed to fix: A lot.Call for participation: Hard difficulty. Experience needed to fix: A lot.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
we should teach bootstrap to respect
--show-output, which in normal libtest prints the output at the end:right now compiletest only supports
--nocapture, which doesn't buffer output at all and as a result ends up interleaved with libtest's own progress reporting.note this is non-trivial because bootstrap reimplements its own formatter for the json output:
rust/src/bootstrap/src/utils/render_tests.rs
Line 214 in 2a71007
Originally posted by @jyn514 in #134111 (comment)