-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
Switch to termcolor (first)? #60349
Copy link
Copy link
Open
Labels
A-libtestArea: `#[test]` / the `test` libraryArea: `#[test]` / the `test` libraryC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
A-libtestArea: `#[test]` / the `test` libraryArea: `#[test]` / the `test` libraryC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.Relevant to the library API team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
No status
There're on going effort to move libtest out of tree, however i think the current approach(#59440) is a little too aggressive by changing everything in a huge PR. I think it the effort should be splitted and happen in several separate steps.
The first big step in it is replacing
libtermwithtermcolor, which means:termcolor,wincolor, andwinapito mark these crates unstable (so they can be shipped with rustc.rust-langorganization.termcolorAn alternative is to keep the existing code for unstable rustc usage but make it a shim over
termcolorfor non-rustc usages.Just wrote these down to see what peoples think. @alexcrichton @Manishearth @gnzlbg @BurntSushi