Skip to content

[BUG] External service got deleted unexpectedly #413

@XinyueZhang369

Description

@XinyueZhang369

What happened?

When disableIngressCreation of config map is set to true, controller will create an external service besides engine/router service. However, the external service will get deleted by cleanup as soon as it's created. Need to fix to skip such external service when cleaning up.

What did you expect to happen?

External service gets created and stay running when disableIngressCreation of config map is set to true

How can we reproduce it (as minimally and precisely as possible)?

Set disableIngressCreation of config map is set to true, then create an inference service

apiVersion: ome.io/v1beta1
kind: InferenceService
metadata:
  name: llama-4-scout-17b-16e-instruct
  namespace: actions-runner-system
  annotations:
    sglang.deployed-by: "manual-test"
spec:
  engine:
    minReplicas: 1
    maxReplicas: 1
  model:
    name: llama-4-scout-17b-16e-instruct

Anything else we need to know?

Environment

  • OME version: ord.ocir.io/idqj093njucb/ome-manager:v0.1.4-36-g0e8110c
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g., from /etc/os-release):
  • Runtime (SGLang, vLLM, etc.) and version:
  • Model being served (if applicable):
  • Install method (Helm, kubectl, etc.):

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions