Bug in error message

[alejandro-colomar]

shadow/src/groupmod.c

Lines 738 to 742 in 655ffcb

	if (pw_open (O_CREAT | O_RDWR) == 0) {
	fprintf (stderr,
	_("%s: cannot open %s\n"),
	Prog, pw_dbname ());
	SYSLOG ((LOG_WARN, "cannot open %s", gr_dbname ()));

This looks like an obvious typo bug, where the author pasted from elsewhere, and forgot to edit.

The commit that introduced the bug was 7fc596f, which contains:

@@ -548,8 +555,8 @@ static void close_files (void)
        if (gflg) {
                if (pw_close () == 0) {
                        fprintf (stderr,
-                                _("%s: cannot rewrite the passwd file\n"), Prog);
-                       SYSLOG ((LOG_WARN, "cannot rewrite the passwd file"));
+                                _("%s: failure while writing changes to %s\n"), Prog, pw_dbname ());
+                       SYSLOG ((LOG_WARN, "failure while writing changes to %s", pw_dbname ()));
 #ifdef WITH_AUDIT
                        audit_logger (AUDIT_USER_CHAUTHTOK, Prog,
                                      "rewrite passwd file",

@ikerexxe , this is another bug in those calls, which would benefit from some global improvements in those calls.

[ikerexxe]

Which calls are you referring to?

[alejandro-colomar]

Which calls are you referring to?

SYSLOG() and fprintf(3). I've seen several bugs (at least 4 that I remember; not counting a general misuse of errno) while doing these simplifications of SYSLOG() and fprintf(3) calls.

[ikerexxe]

Ok, and what do you plan to do? Fix the issue on one side and then simplify the code, or do it altogether?

[alejandro-colomar]

Ok, and what do you plan to do? Fix the issue on one side and then simplify the code, or do it altogether?

Separately, although I'd rather first simplify, and then fix the issues.