Skip to content

Commit d1bbc72

Browse files
ihabadhamclaude
andcommitted
Fix outdated paths after monorepo restructuring
After PR #2114 restructured the monorepo, many path references were not updated. This commit fixes: - GitHub URLs pointing to old paths (spec/dummy, lib/react_on_rails, etc.) - Command examples using `cd spec/dummy` instead of `cd react_on_rails/spec/dummy` - Config files (conductor.json, .stylelintrc.json) with old paths - Relative links in .claude/ documentation - Text references in active documentation files Fixes #2215 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent 8227421 commit d1bbc72

34 files changed

+195
-136
lines changed

.claude/agents/pr-testing-agent.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
- **[PR Testing Guide](pr-testing-guide.md)** - How to use this agent with Claude Code
1212
- [Testing Build Scripts](../docs/testing-build-scripts.md) - Build/package testing requirements
1313
- [CI Config Switching](../../SWITCHING_CI_CONFIGS.md) - Testing minimum vs latest dependencies
14-
- [Local Testing Issues](../../spec/dummy/TESTING_LOCALLY.md) - Environment-specific testing issues
14+
- [Local Testing Issues](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md) - Environment-specific testing issues
1515
- [Master Health Monitoring](../docs/master-health-monitoring.md) - Post-merge CI monitoring
1616
- [CLAUDE.md](../../CLAUDE.md) - Full development guide with CI debugging
1717

@@ -97,7 +97,7 @@ yarn run build # Build succeeds
9797
bundle exec rake autofix # Formatting applied
9898

9999
# MUST test in browser:
100-
cd spec/dummy
100+
cd react_on_rails/spec/dummy
101101
bin/dev # Start servers
102102
# Visit http://localhost:3000/hello_world
103103
# Open browser console - check for errors
@@ -166,7 +166,7 @@ bundle exec rake
166166

167167
```bash
168168
# Create debug script to inspect config:
169-
cd spec/dummy
169+
cd react_on_rails/spec/dummy
170170
cat > debug-webpack.js << 'EOF'
171171
const { generateWebpackConfig } = require('shakapacker');
172172
const config = generateWebpackConfig();
@@ -274,7 +274,7 @@ Changes affecting user-facing behavior require Playwright E2E verification:
274274
**Running Playwright tests:**
275275

276276
```bash
277-
cd spec/dummy
277+
cd react_on_rails/spec/dummy
278278

279279
# Install browsers (one-time setup):
280280
yarn playwright install --with-deps
@@ -311,7 +311,7 @@ Changes to `lib/react_on_rails/engine.rb` or rake tasks require:
311311

312312
```bash
313313
# Test rake task loading (not duplicate execution):
314-
cd spec/dummy
314+
cd react_on_rails/spec/dummy
315315
bundle exec rake -T | grep react_on_rails
316316
# Should see each task ONCE, not duplicated
317317

@@ -377,11 +377,11 @@ Cannot proceed without manual verification.
377377
# Switch to Ruby 3.2 for system tests:
378378
379379
bundle install
380-
cd spec/dummy
380+
cd react_on_rails/spec/dummy
381381
bundle exec rspec spec/system/integration_spec.rb
382382
```
383383

384-
**See [../../spec/dummy/TESTING_LOCALLY.md](../../spec/dummy/TESTING_LOCALLY.md) for details**
384+
**See [../../react_on_rails/spec/dummy/TESTING_LOCALLY.md](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md) for details**
385385

386386
## Success Criteria: Well-Tested PR
387387

.claude/agents/pr-testing-guide.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ git commit -m "Fix helper method"
401401
# Agent responds with checklist
402402

403403
# 5. Complete testing checklist
404-
cd spec/dummy
404+
cd react_on_rails/spec/dummy
405405
bin/dev
406406
# Test in browser...
407407

@@ -446,7 +446,7 @@ gh pr create # Include testing summary from agent
446446

447447
- [ ] Run tests locally: `yarn run test`
448448
- [ ] Build succeeds: `yarn run build`
449-
- [ ] Test in browser: `cd spec/dummy && bin/dev`
449+
- [ ] Test in browser: `cd react_on_rails/spec/dummy && bin/dev`
450450
- [ ] Check browser console for errors
451451
- [ ] If SSR code changed: Verify SSR output in page source
452452

@@ -479,7 +479,7 @@ gh pr create # Include testing summary from agent
479479

480480
#### If user-facing behavior changed (React components, SSR, view helpers):
481481

482-
- [ ] Run Playwright E2E tests: `cd spec/dummy && yarn test:e2e`
482+
- [ ] Run Playwright E2E tests: `cd react_on_rails/spec/dummy && yarn test:e2e`
483483
- [ ] Verify components render in browser
484484
- [ ] Check server-side rendering in view source
485485
- [ ] No JavaScript console errors
@@ -532,7 +532,7 @@ gh pr create # Include testing summary from agent
532532

533533
**Browser testing** - Dummy app visual inspection
534534

535-
cd spec/dummy && bin/dev
535+
cd react_on_rails/spec/dummy && bin/dev
536536
# Visit http://localhost:3000/hello_world
537537
# Check console for errors
538538

@@ -617,7 +617,7 @@ Verified locally:
617617
618618
Tested in dummy app:
619619
```bash
620-
cd spec/dummy
620+
cd react_on_rails/spec/dummy
621621
bin/dev
622622
# Visited http://localhost:3000/hello_world
623623
# ✅ Component renders
@@ -689,5 +689,5 @@ gh pr view --json statusCheckRollup
689689
- Testing build scripts: [../docs/testing-build-scripts.md](../docs/testing-build-scripts.md)
690690
- CI debugging: [CLAUDE.md](../../CLAUDE.md) "Replicating CI Failures Locally"
691691
- Config switching: [SWITCHING_CI_CONFIGS.md](../../SWITCHING_CI_CONFIGS.md)
692-
- Local testing issues: [spec/dummy/TESTING_LOCALLY.md](../../spec/dummy/TESTING_LOCALLY.md)
692+
- Local testing issues: [react_on_rails/spec/dummy/TESTING_LOCALLY.md](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md)
693693
- Master health: [../docs/master-health-monitoring.md](../docs/master-health-monitoring.md)

.claude/docs/analysis/CI_FAILURES_2024-11-21.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ packages/react-on-rails/package.json
276276
277277
- ✅ Webpack bundles cached and restored
278278
- ✅ Node modules installed successfully
279-
- ✅ Bundles present in `spec/dummy/public/webpack`
279+
- ✅ Bundles present in `react_on_rails/spec/dummy/public/webpack`
280280
281281
---
282282
@@ -303,7 +303,7 @@ yarn nps build.prepack
303303
yarn run yalc:publish
304304
305305
# Run failing integration tests
306-
cd spec/dummy
306+
cd react_on_rails/spec/dummy
307307
bundle exec rspec spec/system/integration_spec.rb
308308
309309
# Run failing Pro tests
@@ -322,7 +322,7 @@ timeout 5m yarn run ci
322322
git checkout 5e033c716
323323

324324
# Run same tests
325-
cd spec/dummy
325+
cd react_on_rails/spec/dummy
326326
bundle exec rspec spec/system/integration_spec.rb
327327

328328
# Note differences in:
@@ -342,7 +342,7 @@ git bisect good 5e033c716
342342

343343
# For each bisect step:
344344
yarn install --frozen-lockfile
345-
cd spec/dummy
345+
cd react_on_rails/spec/dummy
346346
bundle exec rspec spec/system/integration_spec.rb:23
347347
git bisect good/bad
348348
```
@@ -388,7 +388,7 @@ git bisect good/bad
388388
```bash
389389
rm -rf node_modules packages/*/lib
390390
yarn install --frozen-lockfile
391-
cd spec/dummy
391+
cd react_on_rails/spec/dummy
392392
bundle exec rspec spec/system/integration_spec.rb:23
393393
```
394394

.claude/docs/analysis/MIGRATION_QUICK_REFERENCE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ packages/node-renderer/ → Keep (Pro only)
3232
```bash
3333
yarn build
3434
yalc publish # Single command at root
35-
cd spec/dummy && yalc add react-on-rails
35+
cd react_on_rails/spec/dummy && yalc add react-on-rails
3636
```
3737

3838
### Target (Surabaya-v1)
3939

4040
```bash
4141
yarn build # Builds all workspaces
4242
yarn yalc:publish # Runs yalc:publish in all workspaces
43-
cd spec/dummy && yalc add react-on-rails
43+
cd react_on_rails/spec/dummy && yalc add react-on-rails
4444
```
4545

4646
## Build Scripts - Path Reference Guide

.claude/docs/analysis/MONOREPO_MIGRATION_ANALYSIS.md

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ react_on_rails/
148148
run: yalc publish
149149

150150
- name: yalc add react-on-rails
151-
run: cd spec/dummy && yalc add react-on-rails
151+
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
152152
```
153153
154154
**Status**: Working in both configurations
@@ -265,10 +265,12 @@ task node_package: "node_package:build"
265265
**Critical**: When migrating from `node_package/` to `packages/react-on-rails/`:
266266
267267
1. **package-scripts.yml** references:
268+
268269
- ❌ `[ -f node_package/lib/ReactOnRails.full.js ]` → ✅ `[ -f lib/ReactOnRails.full.js ]`
269270
- ❌ `[ -f packages/node-renderer/dist/ReactOnRailsProNodeRenderer.js ]` (already correct in Pro)
270271
271272
2. **package.json** "main" and "files" fields:
273+
272274
- Master: `"main": "node_package/lib/ReactOnRails.full.js"`
273275
- Target: `"main": "lib/ReactOnRails.full.js"` (in packages/react-on-rails)
274276
@@ -280,11 +282,13 @@ task node_package: "node_package:build"
280282
#### Workspace Integration Tasks
281283
282284
1. **Yarn workspaces validation**
285+
283286
- Verify all workspace commands work correctly
284287
- Test cross-workspace dependencies
285288
- Validate yalc publish chain
286289
287290
2. **CI/CD Integration**
291+
288292
- Update GitHub Actions for workspace structure
289293
- Verify separate package versioning works
290294
- Test independent package publishing
@@ -333,7 +337,7 @@ task node_package: "node_package:build"
333337
run: yalc publish
334338
335339
- name: yalc add react-on-rails
336-
run: cd spec/dummy && yalc add react-on-rails
340+
run: cd react_on_rails/spec/dummy && yalc add react-on-rails
337341
```
338342

339343
**Current Limitation**:
@@ -371,24 +375,28 @@ task node_package: "node_package:build"
371375
⚠️ **Critical Path Issues**:
372376

373377
1. **Path References** (HIGHEST PRIORITY)
378+
374379
- [ ] Update all hardcoded `node_package/lib/` references
375380
- [ ] Verify `package-scripts.yml` paths after migration
376381
- [ ] Test `yalc publish` with new paths
377382
- **Impact**: Breaking yalc publish silently (as happened in Sept 2024)
378383

379384
2. **Workspace Integration** (HIGH)
385+
380386
- [ ] Validate `yarn workspaces run yalc:publish`
381387
- [ ] Test cross-workspace dependency resolution
382388
- [ ] Verify package version management
383389
- **Impact**: Package installation failures for users
384390

385391
3. **CI/CD Consolidation** (HIGH)
392+
386393
- [ ] Merge CircleCI into GitHub Actions workflow
387394
- [ ] Test all CI jobs with workspace structure
388395
- [ ] Update caching strategies for workspaces
389396
- **Impact**: Unpredictable CI behavior, missing test coverage
390397

391398
4. **Pro Package Migration** (MEDIUM)
399+
392400
- [ ] Consolidate `react_on_rails_pro/` with `packages/react-on-rails-pro/`
393401
- [ ] Remove redundant configurations
394402
- [ ] Update build scripts
@@ -483,11 +491,13 @@ GitHub Actions
483491
### Phase 3: Pre-Monorepo Structure Preparation
484492

485493
1. **Validate Current State**
494+
486495
- [ ] Run full test suite on surabaya-v1
487496
- [ ] Verify yalc publish works with workspace structure
488497
- [ ] Test clean install scenarios
489498

490499
2. **Path Migration Checklist**
500+
491501
- [ ] Update all `package-scripts.yml` paths
492502
- [ ] Update all CI workflow paths
493503
- [ ] Search codebase for hardcoded `node_package/` references
@@ -501,11 +511,13 @@ GitHub Actions
501511
### Phase 4: Final Monorepo Restructuring
502512

503513
1. **Consolidate Pro Package**
514+
504515
- [ ] Merge `react_on_rails_pro/` into monorepo structure
505516
- [ ] Remove redundant configurations
506517
- [ ] Update gemspec files
507518

508519
2. **CI/CD Consolidation**
520+
509521
- [ ] Move CircleCI jobs to GitHub Actions
510522
- [ ] Update workspace cache strategies
511523
- [ ] Verify all test jobs pass
@@ -522,23 +534,27 @@ GitHub Actions
522534
**Migration will be complete when**:
523535

524536
1. **Structure**
537+
525538
- All JavaScript packages in `packages/` directory
526539
- Yarn workspaces configured and working
527540
- No references to `node_package/src/` in documentation
528541

529542
2. **Build & Package**
543+
530544
- `yarn build` compiles all packages
531545
- `yarn yalc:publish` publishes all packages
532546
- `yarn run prepack` passes pre-publication checks
533547
- All build artifacts in expected locations
534548

535549
3. **Testing**
550+
536551
- All RSpec tests pass (Ruby)
537552
- All Jest tests pass (JavaScript)
538553
- CI/CD pipeline fully operational
539554
- Clean install works for all package types
540555

541556
4. **Documentation**
557+
542558
- All developer instructions updated
543559
- Path references accurate
544560
- Release process documented

.claude/docs/analysis/PHASE_6_CHECKLIST.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ Most should still work, but verify paths like:
624624
- [ ] Test core dummy app:
625625

626626
```bash
627-
cd spec/dummy
627+
cd react_on_rails/spec/dummy
628628
bundle install
629629
yarn install
630630
yarn build

.stylelintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"function-url-quotes": null
3838
},
3939
"ignoreFiles": [
40-
"spec/dummy/app/assets/stylesheets/application.css",
40+
"react_on_rails/spec/dummy/app/assets/stylesheets/application.css",
4141
"**/*.js",
4242
"**/*.jsx",
4343
"**/*.ts",

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1687,7 +1687,7 @@ All 5.1.0 changes can be found in [#362](https://github.com/shakacode/react_on_r
16871687

16881688
##### Migration Steps v2 to v3
16891689

1690-
- See [these changes of spec/dummy/spec/rails_helper.rb](https://github.com/shakacode/react_on_rails/blob/master/spec/dummy/spec/rails_helper.rb#L36..38) for an example. Add this line to your `rails_helper.rb`:
1690+
- See [these changes of spec/dummy/spec/rails_helper.rb](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails/spec/dummy/spec/rails_helper.rb#L36..38) for an example. Add this line to your `rails_helper.rb`:
16911691

16921692
```ruby
16931693
RSpec.configure do |config|

0 commit comments

Comments
 (0)