docs: add omni join token example to create qemu command #12348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
reviewed
Dec 5, 2025
| func addOmniJoinTokenFlag(cmd *cobra.Command, bindAPIEndpoint *string, cfgPatchAllFlagName, cfgPatchWorkersFlagName, cfgPatchCPsFlagName string) { | ||
| cmd.Flags().StringVar(bindAPIEndpoint, omniAPIEndpointFlagName, *bindAPIEndpoint, "the Omni API endpoint (must include a scheme, a port and a join token)") | ||
| cmd.Flags().StringVar(bindAPIEndpoint, omniAPIEndpointFlagName, *bindAPIEndpoint, | ||
| "the Omni API endpoint (must include a scheme, a port and a join token, e.g. 'grpc://omni.com:8090?jointoken=foobar')") |
Member
There was a problem hiding this comment.
let's do an example which matches more production Omni
Suggested change
| "the Omni API endpoint (must include a scheme, a port and a join token, e.g. 'grpc://omni.com:8090?jointoken=foobar')") | |
| "the Omni API endpoint (must include a scheme, a port and a join token, e.g. 'https://siderolink.omni.example?jointoken=foobar')") |
Member
Author
There was a problem hiding this comment.
Is having no port number more usual?
Member
There was a problem hiding this comment.
yep, it should be proper https:// usually.
Orzelius
force-pushed
the
create-qemu-preset-docs
branch
from
dbd0ab2 to
f810f62
Compare
smira
approved these changes
Dec 5, 2025
Orzelius
force-pushed
the
create-qemu-preset-docs
branch
from
f810f62 to
c6519ea
Compare
this will hopefully reduce confusion on what the flag value should look like Signed-off-by: Orzelius <[email protected]>
Orzelius
force-pushed
the
create-qemu-preset-docs
branch
from
c6519ea to
fc8ae32
Compare
Member
Author
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will hopefully reduce confusion on what the flag value should look like