Non-Blocking Review Concern: caddy-health.sh contains unsubstituted OPERATOR_USERNAME placeholders
Source: sentry[bot]
Location: app-setup/templates/caddy-health.sh:110
PR: #106 — feat(caddy): import tilsit-caddy into mac-server-setup (#106)
Merged: 2026-04-03
What was flagged
The health check script has literal __OPERATOR_USERNAME__ on lines 110 and ~131 (DEPLOY_CADDYFILE path and error log path). If caddy-setup.sh does not run template substitution on this file, Test 8 (Configuration) will always report a false negative, and the displayed log path will be wrong. The fix is to either add caddy-health.sh to the list of files processed by substitute_template() in caddy-setup.sh, or replace the placeholder with a runtime $(whoami) or ${USER} lookup since this is a manually-run diagnostic script.
Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #106. It was safe to merge but worth tracking.
Created by pre-merge-review.sh
Non-Blocking Review Concern: caddy-health.sh contains unsubstituted OPERATOR_USERNAME placeholders
Source: sentry[bot]
Location:
app-setup/templates/caddy-health.sh:110PR: #106 — feat(caddy): import tilsit-caddy into mac-server-setup (#106)
Merged: 2026-04-03
What was flagged
The health check script has literal
__OPERATOR_USERNAME__on lines 110 and ~131 (DEPLOY_CADDYFILE path and error log path). Ifcaddy-setup.shdoes not run template substitution on this file, Test 8 (Configuration) will always report a false negative, and the displayed log path will be wrong. The fix is to either addcaddy-health.shto the list of files processed bysubstitute_template()incaddy-setup.sh, or replace the placeholder with a runtime$(whoami)or${USER}lookup since this is a manually-run diagnostic script.Context
This issue was automatically created from a non-blocking concern identified
during pre-merge review of PR #106. It was safe to merge but worth tracking.
Created by pre-merge-review.sh