Skip to content

Fix Iceberg incremental read option conflict detection - #4302

Open
fallintoplace wants to merge 1 commit into
snowflakedb:mainfrom
fallintoplace:fix-iceberg-reader-option-conflicts
Open

Fix Iceberg incremental read option conflict detection#4302
fallintoplace wants to merge 1 commit into
snowflakedb:mainfrom
fallintoplace:fix-iceberg-reader-option-conflicts

Conversation

@fallintoplace

Copy link
Copy Markdown

Summary

  • normalize incremental-read and time-travel option keys before comparing them
  • detect conflicts for version_ref, branch, and tag reader options
  • add parameterized coverage for casing and hyphen/underscore variants

DataFrameReader.option() stores keys in uppercase, while the incremental-read detector compared those keys against lowercase values. As a result, the detector returned early and allowed time-travel options to be silently ignored when incremental reads were configured.

Testing

  • python -m pytest tests/unit/test_utils.py -q
  • pre-commit run --files src/snowflake/snowpark/dataframe_reader.py tests/unit/test_utils.py

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@fallintoplace

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant