Commit a63066b
committed
fix: make closeOnBeforeunload default to false
Silently closing the connection when receiving a "beforeunload" event
is problematic, because it is emitted:
- when downloading a file from another host
Related: socketio/socket.io#4436
- when the user already has a listener for the "beforeunload" event
(i.e. "are you sure you want to leave this page?")
Related:
- #661
- #658
- socketio/socket.io#4065
That's why the `closeOnBeforeunload` option will now default to false.1 parent 1fc61a3 commit a63066b
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| |||
347 | 347 | | |
348 | 348 | | |
349 | 349 | | |
350 | | - | |
| 350 | + | |
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| |||
0 commit comments