I'm discovering that if there's an error during parsing, MidParser does not emit it, and the stream is silently destroyed. This might be caused by something I did while tinkering with the project, but it'd really help if I had some context about this section:
|
_destroy() { |
|
//no-op, needed to handle older node versions |
|
} |
It seems to be responsible for why the error gets eaten. If I remove it, the default handler emits the error event correctly.
How did earlier versions of node behave that prompted _destroy() to become a noop? I'd like to fix this without breaking backwards compat, but can't do that without more history on why it was added.
(I'm using node v14 btw)
I'm discovering that if there's an error during parsing, MidParser does not emit it, and the stream is silently destroyed. This might be caused by something I did while tinkering with the project, but it'd really help if I had some context about this section:
node-open-protocol/src/MIDParser.js
Lines 71 to 73 in f514d00
It seems to be responsible for why the error gets eaten. If I remove it, the default handler emits the error event correctly.
How did earlier versions of node behave that prompted _destroy() to become a noop? I'd like to fix this without breaking backwards compat, but can't do that without more history on why it was added.
(I'm using node v14 btw)