-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
enhancementNew feature or requestNew feature or request
Description
#86 introduced some support for disabling automatic serialization - however:
- using a macro cache has undesireable complexity of usage - for example, if
a.nimcallssetAutoSerialize(true)andb.nimdoesn't, serialization inb.nimwill work or not depending on import order and / or whetherawas imported at all - for example, compilingaandbtogether will work, but compilingbon its own will not (this can be seen in the json-rpc test suite wheretest_router_rpccompiles when part ofall_testsbut not on its own because the automatic serialization is configured in some other test - if two modules set opposite values, the semantics are unclear - having
setAutoSerializetake a boolean parameter is difficult to understand and work with - the API is unclear - why is
setAutoSerializedifferent fromuseDefaultSerializationInand why can't the latter be used for auto-serialization of primitives? the inconsistency makes the API hard to understand when there are two similar ways of doing the same thing (enabling "default" serialization for a type)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request