[Status Network Contracts] Revisit leave mechanism as it allows for free rewards #78
Description
Context: https://github.com/Cyfrin/audit-2025-12-statusl2/issues/10
TLDR:
- Leaving always enables withdrawal of funds unless they are locked
- Leaving assumes that StakeManager always does proper accounting (either that, or it fails and we don't care)
- There's a case where it fails and we do care, which is when StakeManager is paused
- In this case, user stakes, manager pauses, user leaves (manager reverts), user receives funds
- User can now still redeem funds because manager never updated its state during pause
We need to think about how to fix this.
The problem is the try/catch block, but it's also there for a reason.