Why is Manual boiler switch commented out?

[asantaga]

going through the code I noticed that manual boiler switch is commeted out in both max.py and heatinggpio.py, just wondering why? its controlled by flags

[stephenmhall]

Without looking at my code it might be left over code from an earlier implementation of a manual switch. I will have a look.

[stephenmhall]

Ok I found it, and I think everything is ok I must have been moving the code that switched a relay around and not tidied up, the relay output BOILER_SW(GPIO21) is switched inside the setstatuslights function along with the status led's, if you use the neopixel code it is sent in the serial data to the daughter esp8266 that controles the neopixel and the relay switching is done there. So as long as ManualHeatingSwitch is set to 1 in the variables.txt file you should get switching. I will look at enabling / disabling the vera code via a flag. that is a good idea.

[asantaga]

Cool, I'll have some time this weekend to hack around, I'll fork your repo , and make some of the changes for you, you can then pull them back into your master.

[asantaga]

Hi Stephen Sorry to bug. All is good with the PiHeating its now in "production" and working well.. Im using it with HomeAssistant (for the rules) so not 100% sure I'll ever rewrite the UI/requestHandler (not broken not fixing it) but I do have one question.. How do you set the heating mode to "ECO"?? Ive looked at your code and I see u set the valve mode to "none", but when I execute this I the TRV goes to the open window mode (12c) instead of the eco (15c).. Is this on purpose?

…

On Wed, Nov 16, 2016 at 5:02 PM, Stephen Hall ***@***.***> wrote: Without looking at my code it might be left over code from an earlier implementation of a manual switch. I will have a look. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzdQEL1lf30PC8nsYr0zysFJgFj8GQLks5q-zcMgaJpZM4KzMrG> .

-- Angelo

[stephenmhall]

If I remember I could never find the command to set eco mode, I went through the documentation of the person who had reveresed engineered the MAX protocol but couldn't find it. so that would fit into the work in progress pile. There were a few things I never managed to find out how they were set. Stephen

…

________________________________ From: Angelo Santagata <notifications@github.com> Sent: 29 March 2018 11:32 To: stephenmhall/PiHeating Cc: Stephen Hall; Comment Subject: Re: [stephenmhall/PiHeating] Why is Manual boiler switch commented out? (#3) Hi Stephen Sorry to bug. All is good with the PiHeating its now in "production" and working well.. Im using it with HomeAssistant (for the rules) so not 100% sure I'll ever rewrite the UI/requestHandler (not broken not fixing it) but I do have one question.. How do you set the heating mode to "ECO"?? Ive looked at your code and I see u set the valve mode to "none", but when I execute this I the TRV goes to the open window mode (12c) instead of the eco (15c).. Is this on purpose?

On Wed, Nov 16, 2016 at 5:02 PM, Stephen Hall ***@***.***> wrote: Without looking at my code it might be left over code from an earlier implementation of a manual switch. I will have a look. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzdQEL1lf30PC8nsYr0zysFJgFj8GQLks5q-zcMgaJpZM4KzMrG> .

-- Angelo — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fstephenmhall%2FPiHeating%2Fissues%2F3%23issuecomment-377194116&data=02%7C01%7C%7C83c00a0a8c164c96aa0b08d595605615%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636579163342575459&sdata=tneMuI1pDjW%2BJpr32qn%2BtfvcHIf6trmLkF%2FNoxVf3Qg%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGg8sooOaYLZpnZ9GSnQl3dgRpXIEJ05ks5tjLgsgaJpZM4KzMrG&data=02%7C01%7C%7C83c00a0a8c164c96aa0b08d595605615%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636579163342575459&sdata=v6OzLEOPyxgRfkntNaGXIb50ePyf%2FW91tbbfTupuUFk%3D&reserved=0>.

[asantaga]

NP, From what I can see if I set the mode to 'none' it sets it to 12c which happens to be the same as "window opened".. which kinda works.. :-) thanks again Angelo On Thu, Mar 29, 2018 at 10:04 PM, Stephen Hall <notifications@github.com> wrote:

…

If I remember I could never find the command to set eco mode, I went through the documentation of the person who had reveresed engineered the MAX protocol but couldn't find it. so that would fit into the work in progress pile. There were a few things I never managed to find out how they were set. Stephen ________________________________ From: Angelo Santagata ***@***.***> Sent: 29 March 2018 11:32 To: stephenmhall/PiHeating Cc: Stephen Hall; Comment Subject: Re: [stephenmhall/PiHeating] Why is Manual boiler switch commented out? (#3) Hi Stephen Sorry to bug. All is good with the PiHeating its now in "production" and working well.. Im using it with HomeAssistant (for the rules) so not 100% sure I'll ever rewrite the UI/requestHandler (not broken not fixing it) but I do have one question.. How do you set the heating mode to "ECO"?? Ive looked at your code and I see u set the valve mode to "none", but when I execute this I the TRV goes to the open window mode (12c) instead of the eco (15c).. Is this on purpose? On Wed, Nov 16, 2016 at 5:02 PM, Stephen Hall ***@***.***> wrote: > Without looking at my code it might be left over code from an earlier > implementation of a manual switch. I will have a look. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/stephenmhall/PiHeating/issues/ 3#issuecomment-261005451>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ ACzdQEL1lf30PC8nsYr0zysFJgFj8GQLks5q-zcMgaJpZM4KzMrG> > . > -- Angelo — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://eur01. safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. com%2Fstephenmhall%2FPiHeating%2Fissues%2F3%23issuecomment-377194116&data= 02%7C01%7C%7C83c00a0a8c164c96aa0b08d595605615% 7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636579163342575459&sdata= tneMuI1pDjW%2BJpr32qn%2BtfvcHIf6trmLkF%2FNoxVf3Qg%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook. com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth% 2FAGg8sooOaYLZpnZ9GSnQl3dgRpXIEJ05ks5tjLgsgaJpZM4KzMrG&data=02%7C01%7C% 7C83c00a0a8c164c96aa0b08d595605615%7C84df9e7fe9f640afb435aaaaaaaa aaaa%7C1%7C0%7C636579163342575459&sdata=v6OzLEOPyxgRfkntNaGXIb50ePyf% 2FW91tbbfTupuUFk%3D&reserved=0>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACzdQCp33dJMiy2YsfSgqBMvq_ui8CHwks5tjUxMgaJpZM4KzMrG> .

-- Angelo

[asantaga]

Hey I know you dont have this system anymore but I thought Id let u know I sussed it! The eco temps are send out when you first connect to the cube in the "C" messages.. The way "eco mode" works, is the cube receives the message and then sets each valve separately to that temp.. its kinda strange it isnt sent out during the M message but ho hum.. :-) On Thu, Mar 29, 2018 at 10:45 PM, Angelo Santagata < angelosantagata@gmail.com> wrote:

…

NP, From what I can see if I set the mode to 'none' it sets it to 12c which happens to be the same as "window opened".. which kinda works.. :-) thanks again Angelo On Thu, Mar 29, 2018 at 10:04 PM, Stephen Hall ***@***.***> wrote: > If I remember I could never find the command to set eco mode, I went > through the documentation of the person who had reveresed engineered the > MAX protocol but couldn't find it. so that would fit into the work in > progress pile. There were a few things I never managed to find out how they > were set. > > Stephen > ________________________________ > From: Angelo Santagata ***@***.***> > Sent: 29 March 2018 11:32 > To: stephenmhall/PiHeating > Cc: Stephen Hall; Comment > Subject: Re: [stephenmhall/PiHeating] Why is Manual boiler switch > commented out? (#3) > > Hi Stephen > > Sorry to bug. All is good with the PiHeating its now in "production" and > working well.. Im using it with HomeAssistant (for the rules) so not 100% > sure I'll ever rewrite the UI/requestHandler (not broken not fixing it) > but > I do have one question.. > > How do you set the heating mode to "ECO"?? > > Ive looked at your code and I see u set the valve mode to "none", but when > I execute this I the TRV goes to the open window mode (12c) instead of the > eco (15c).. Is this on purpose? > > > > > On Wed, Nov 16, 2016 at 5:02 PM, Stephen Hall ***@***.***> > wrote: > > > Without looking at my code it might be left over code from an earlier > > implementation of a manual switch. I will have a look. > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub > > <#3# > issuecomment-261005451>, > > or mute the thread > > <https://github.com/notifications/unsubscribe-auth/ACzdQEL1l > f30PC8nsYr0zysFJgFj8GQLks5q-zcMgaJpZM4KzMrG> > > . > > > > > > -- > > > Angelo > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub<https://eur01.safelinks > .protection.outlook.com/?url=https%3A%2F%2Fgithub.com% > 2Fstephenmhall%2FPiHeating%2Fissues%2F3%23issuecomment- > 377194116&data=02%7C01%7C%7C83c00a0a8c164c96aa0b08d595605615 > %7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C63657916334257 > 5459&sdata=tneMuI1pDjW%2BJpr32qn%2BtfvcHIf6trmLkF% > 2FNoxVf3Qg%3D&reserved=0>, or mute the thread<https://eur01.safelinks > .protection.outlook.com/?url=https%3A%2F%2Fgithub.com% > 2Fnotifications%2Funsubscribe-auth%2FAGg8sooOaYLZpnZ9GSnQl3d > gRpXIEJ05ks5tjLgsgaJpZM4KzMrG&data=02%7C01%7C%7C83c00a0a8c16 > 4c96aa0b08d595605615%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1% > 7C0%7C636579163342575459&sdata=v6OzLEOPyxgRfkntNaGXIb50 > ePyf%2FW91tbbfTupuUFk%3D&reserved=0>. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACzdQCp33dJMiy2YsfSgqBMvq_ui8CHwks5tjUxMgaJpZM4KzMrG> > . > -- Angelo

-- Angelo