Merge pull request #2379 from ahoppen/log-unkown-notification

ahoppen · web-flow · commit 8713afa7a1ce · 2025-12-05T00:25:49.000+01:00
Log an error when ignoring an unknown notification sent by the client
diff --git a/Sources/SourceKitLSP/SourceKitLSPServer.swift b/Sources/SourceKitLSP/SourceKitLSPServer.swift
@@ -700,7 +700,7 @@ extension SourceKitLSPServer: QueueBasedMessageHandler {
       await self.withLanguageServiceAndWorkspace(for: notification, notificationHandler: self.willSaveDocument)
     // IMPORTANT: When adding a new entry to this switch, also add it to the `MessageHandlingDependencyTracker` initializer.
     default:
-      break
+      logger.error("Ignoring unknown notification \(type(of: notification).method)")
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -700,7 +700,7 @@ extension SourceKitLSPServer: QueueBasedMessageHandler {`
`700`	`700`	`await self.withLanguageServiceAndWorkspace(for: notification, notificationHandler: self.willSaveDocument)`
`701`	`701`	// IMPORTANT: When adding a new entry to this switch, also add it to the `MessageHandlingDependencyTracker` initializer.
`702`	`702`	`default:`
`703`		`- break`
	`703`	`+ logger.error("Ignoring unknown notification \(type(of: notification).method)")`
`704`	`704`	`}`
`705`	`705`	`}`
`706`	`706`