Address review feedback on reqrespupdate

- Bound the test retry helper with a max attempt count and a short sleep, so
  a workflow that stops continuing as new fails the test instead of retrying
  forever and hanging CI.
- Skip both tests on the time-skipping server, matching the other update
  tests in the repo (temporalio/sdk-java#1903).
- Reject requests_before_continue_as_new < 1 in the workflow constructor.
  Zero made the run continue as new immediately and forever while rejecting
  every request.
- Move TASK_QUEUE and WORKFLOW_ID into __init__.py, as sleep_for_days and
  message_passing/waiting_for_handlers do, instead of the worker hardcoding
  the task queue name.
- Use the existing handle in the continue-as-new test rather than re-fetching
  it; start_workflow does not pin the handle to a run.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: barmoshe

reqrespupdate/__init__.py

@@ -0,0 +1,2 @@
+TASK_QUEUE = "reqrespupdate-task-queue"
+WORKFLOW_ID = "reqrespupdate-workflow-id"

reqrespupdate/requester.py

@@ -4,7 +4,7 @@
 from temporalio.envconfig import ClientConfig
 from temporalio.exceptions import ApplicationError
 
-from reqrespupdate.starter import WORKFLOW_ID
+from reqrespupdate import WORKFLOW_ID
 from reqrespupdate.workflow import BACKOFF_ERROR_TYPE, Request, UppercaseWorkflow
 
 

reqrespupdate/starter.py

@@ -3,11 +3,9 @@
 from temporalio.client import Client
 from temporalio.envconfig import ClientConfig
 
+from reqrespupdate import TASK_QUEUE, WORKFLOW_ID
 from reqrespupdate.workflow import UppercaseWorkflow, UppercaseWorkflowInput
 
-WORKFLOW_ID = "reqrespupdate-workflow-id"
-TASK_QUEUE = "reqrespupdate-task-queue"
-
 
 async def main():
     config = ClientConfig.load_client_connect_config()

reqrespupdate/worker.py

@@ -5,6 +5,7 @@
 from temporalio.envconfig import ClientConfig
 from temporalio.worker import Worker
 
+from reqrespupdate import TASK_QUEUE
 from reqrespupdate.activities import uppercase
 from reqrespupdate.workflow import UppercaseWorkflow
 
@@ -18,7 +19,7 @@ async def main():
 
     async with Worker(
         client,
-        task_queue="reqrespupdate-task-queue",
+        task_queue=TASK_QUEUE,
         workflows=[UppercaseWorkflow],
         activities=[uppercase],
     ):

reqrespupdate/workflow.py

@@ -53,6 +53,13 @@ class UppercaseWorkflow:
 
     @workflow.init
     def __init__(self, input: UppercaseWorkflowInput) -> None:
+        # A run has to accept at least one request, otherwise it continues as
+        # new the moment it starts and the chain never does any work.
+        if input.requests_before_continue_as_new < 1:
+            raise ApplicationError(
+                "requests_before_continue_as_new must be at least 1",
+                non_retryable=True,
+            )
         self.input = input
         self.request_count = 0
 

tests/reqrespupdate/workflow_test.py

@@ -1,7 +1,10 @@
+import asyncio
 import uuid
 
+import pytest
 from temporalio.client import Client, WorkflowUpdateFailedError
 from temporalio.exceptions import ApplicationError
+from temporalio.testing import WorkflowEnvironment
 from temporalio.worker import Worker
 
 from reqrespupdate.activities import uppercase
@@ -13,12 +16,14 @@
 )
 
 
-async def request_uppercase(handle, text: str) -> str:
+async def request_uppercase(handle, text: str, max_attempts: int = 10) -> str:
     """Request an uppercasing, retrying if the workflow is continuing as new.
 
-    This is the same backoff the requester in this sample performs.
+    This is the same backoff the requester in this sample performs, bounded so
+    that a workflow which never continues as new fails the test instead of
+    retrying forever.
     """
-    while True:
+    for _ in range(max_attempts):
         try:
             response = await handle.execute_update(
                 UppercaseWorkflow.uppercase, Request(input=text)
@@ -29,11 +34,19 @@ async def request_uppercase(handle, text: str) -> str:
                 isinstance(err.cause, ApplicationError)
                 and err.cause.type == BACKOFF_ERROR_TYPE
             ):
+                await asyncio.sleep(0.1)
                 continue
             raise
+    raise AssertionError(
+        f"Request for {text} still rejected after {max_attempts} attempts"
+    )
 
 
-async def test_uppercase(client: Client):
+async def test_uppercase(client: Client, env: WorkflowEnvironment):
+    if env.supports_time_skipping:
+        pytest.skip(
+            "Java test server: https://github.com/temporalio/sdk-java/issues/1903"
+        )
     task_queue = f"tq-{uuid.uuid4()}"
     async with Worker(
         client,
@@ -54,7 +67,13 @@ async def test_uppercase(client: Client):
             await handle.terminate()
 
 
-async def test_continues_as_new_without_losing_requests(client: Client):
+async def test_continues_as_new_without_losing_requests(
+    client: Client, env: WorkflowEnvironment
+):
+    if env.supports_time_skipping:
+        pytest.skip(
+            "Java test server: https://github.com/temporalio/sdk-java/issues/1903"
+        )
     task_queue = f"tq-{uuid.uuid4()}"
     async with Worker(
         client,
@@ -78,7 +97,7 @@ async def test_continues_as_new_without_losing_requests(client: Client):
             for i in range(6):
                 assert await request_uppercase(handle, f"foo{i}") == f"FOO{i}"
 
-            description = await client.get_workflow_handle(handle.id).describe()
+            description = await handle.describe()
             assert description.run_id != handle.first_execution_run_id
         finally:
-            await client.get_workflow_handle(handle.id).terminate()
+            await handle.terminate()