Repository navigation
fix: ignore Task<T> result for activities declared as Task - #999
Open
ahmad-codex wants to merge 2 commits into
Open
ahmad-codex wants to merge 2 commits into
ahmad-codex wants to merge 2 commits into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an activity is declared as
Taskbut returns aTask<T>at runtime (e.g. forwarding a call without async/await), the worker recorded the innerTas the result.InvokeAsyncchecked the runtime type of the returned task, not the declared return type, so a large object could land in history or fail with PayloadsTooLarge.Now an activity declared as non-generic
Taskalways completes with no result. Everything else behaves as before.Added a test in
ActivityDefinitionTestsfor aTask-declared delegate returningTask.FromResult(...). It fails without the fix.Fixes #975