From cdb482587300c6cd1cccf68c1730dec62691b85a Mon Sep 17 00:00:00 2001
From: Jonathan Csanyi <jdc@csanyi.ca>
Date: Sat, 15 Aug 2026 13:45:12 -0300
Subject: [PATCH] Add DISCOVERY_DIAGNOSTIC environment variable

Theengs Gateway can mark battery, voltage and RSSI entities with Home
Assistant's diagnostic entity category, but start.sh regenerates
theengsgw.conf from a fixed set of keys on every start, so the option
was unreachable from Docker except through the PARAMS passthrough.

Validated like the other boolean variables and defaulting to false,
matching the gateway's own default. The key is ignored by gateway
versions that don't know it, so this is inert until the pinned version
supports the option.
---
 README.md                   | 2 ++
 chroot/opt/venv/start.sh    | 8 ++++++++
 examples/docker-compose.yml | 1 +
 3 files changed, 11 insertions(+)

diff --git a/README.md b/README.md
index 0f8ead4..b3b9992 100644
--- a/README.md
+++ b/README.md
@@ -51,6 +51,7 @@ services:
       DISCOVERY_TOPIC: homeassistant
       DISCOVERY_DEVICE_NAME: TheengsGateway
       DISCOVERY_FILTER: "[IBEACON,GAEN,MS-CDP]"
+      DISCOVERY_DIAGNOSTIC: true
       SCANNING_MODE: active
       ADAPTER: hci0
       TIME_SYNC: "[]"
@@ -123,6 +124,7 @@ docker run --rm \
     -e DISCOVERY_TOPIC=homeassistant \
     -e DISCOVERY_DEVICE_NAME=TheengsGateway \
     -e DISCOVERY_FILTER="[IBEACON]" \
+    -e DISCOVERY_DIAGNOSTIC=true \
     -e SCANNING_MODE=active \
     -e ADAPTER=hci0 \
     -e TIME_SYNC="[]" \
diff --git a/chroot/opt/venv/start.sh b/chroot/opt/venv/start.sh
index bc046be..7c88811 100755
--- a/chroot/opt/venv/start.sh
+++ b/chroot/opt/venv/start.sh
@@ -118,6 +118,13 @@ if hasvalue $HASS_DISCOVERY; then
 	fi
 fi
 
+if hasvalue $DISCOVERY_DIAGNOSTIC; then
+	if ! [[ $DISCOVERY_DIAGNOSTIC =~ (true|false) ]]; then
+		echo "WARNING : Wrong value for DISCOVERY_DIAGNOSTIC environment variable, will use default - false"
+		DISCOVERY_DIAGNOSTIC=false
+	fi
+fi
+
 if hasvalue $PASSIVE_SCAN; then
 	# Deprecation warning, this was written before 0.5.0 was released , will use SCANNIN_MODE in future
 	echo "PASSIVE_SCAN : Deprecated environment variable, this variable will be removed in future versions, please use SCANNING_MODE=active|passive"
@@ -216,6 +223,7 @@ echo "Creating config at $CONFIG ..."
     "discovery_topic": "${DISCOVERY_TOPIC:-homeassistant/sensor}",
     "discovery_device_name": "${DISCOVERY_DEVICE_NAME:-TheengsGateway}",
     "discovery_filter": "${DISCOVERY_FILTER:-[IBEACON]}",
+    "discovery_diagnostic": ${DISCOVERY_DIAGNOSTIC:-false},
     "scanning_mode": "${SCANNING_MODE:-active}",
     "adapter": "${ADAPTER:-hci0}",
     "time_sync": "${TIME_SYNC:-[]}",
diff --git a/examples/docker-compose.yml b/examples/docker-compose.yml
index a8c8b97..3ff4e22 100644
--- a/examples/docker-compose.yml
+++ b/examples/docker-compose.yml
@@ -24,6 +24,7 @@ services:
       DISCOVERY_TOPIC: homeassistant
       DISCOVERY_DEVICE_NAME: TheengsGateway
       DISCOVERY_FILTER: "[IBEACON]"
+      DISCOVERY_DIAGNOSTIC: true
       SCANNING_MODE: active
       ADAPTER: hci0
       BINDKEYS: "{}"