Fixes #38909 - Use syslog gem not in windows #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Nov 17, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Could you open a Redmine issue for this?
I'd also love to have some CI on GHA that uses a Windows runner to test if it works, but lack the specific knowledge (and time). Do you have any idea how hard that would be?
sbernhard
force-pushed
the
syslog_not_for_win
branch
from
9475601 to
26d48a1
Compare
sbernhard
changed the title
sbernhard
force-pushed
the
syslog_not_for_win
branch
16 times, most recently
from
1b37d01 to
6f459ce
Compare
ekohl
reviewed
Nov 17, 2025
sbernhard
force-pushed
the
syslog_not_for_win
branch
from
6f459ce to
a26d0a0
Compare
sbernhard
force-pushed
the
syslog_not_for_win
branch
4 times, most recently
from
d0b9550 to
d798c3f
Compare
sbernhard
force-pushed
the
syslog_not_for_win
branch
from
0acc281 to
cf25385
Compare
|
@sbernhard Please create a Redmine issue & have a look at the failing tests. Please ping Ewoud after GHA are 🍏 for a final ACK. edit: apologies; Redmine issue is open but GHA still fails. There must be another reason for that. |
Contributor
Author
everything done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.