Feat(duckdb): Add transpilation support for the negative integer args for BITNOT #6490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-amrutabhimsenayachit
requested review from
fivetran-BradfordPaskewitz and
georgesittas
VaggelisD
changed the title
VaggelisD
changed the title
Collaborator
|
Apologies for the title change, wanted to amend a different PR. |
VaggelisD
approved these changes
Dec 5, 2025
sqlglot/dialects/duckdb.py
Outdated
Comment on lines
1665
to
1669
| this_sql = self.sql(expression, "this") | ||
| # Wrap in parentheses if starts with minus to prevent ~- parsing issues | ||
| if this_sql.startswith("-"): | ||
| this_sql = f"({this_sql})" | ||
| return f"~{this_sql}" |
Collaborator
There was a problem hiding this comment.
[Nit] It is generally better if we can avoid string logic and instead construct/transform expressions, we can rewrite this as:
Suggested change
| this_sql = self.sql(expression, "this") | |
| # Wrap in parentheses if starts with minus to prevent ~- parsing issues | |
| if this_sql.startswith("-"): | |
| this_sql = f"({this_sql})" | |
| return f"~{this_sql}" | |
| this = expression.this | |
| # Wrap in parentheses to prevent parsing issues such as "SELECT ~-1" | |
| if isinstance(this, exp.Neg): | |
| this = exp.Paren(this=this) | |
| return f"~{self.sql(this)}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transpilation support for the negative integer args for BITNOT