Skip to content

Date 12/31/17 incorrectly given format of YYYY/M/D #32

Description

@matthias-ccri

A date string like 12/31/17 is incorrectly given the YYYY/M/D format, whereas it should be M/D/YYYY.

It looks like there are unit tests that try to cover this:

arr = ['1/1/15', '11/2/98', '1/31/00', '12/31/17'].map(mapArr);
result = Analyzer.computeColMeta(arr)[0];
assert.deepEqual({type: result.type, format: result.format},
{type: 'DATE', format: 'M/D/YYYY'},
'Inteprets dates formatted as M/D/YYYY correctly');

but not all of the dates are actually tested. If you change the order of the dates and make 12/31/17 first, the test fails.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions