Fix compilation failure when "gif" feature not enabled (#893)

* Fix compilation failure when "compress" feature not enabled

* Fix compilation failure when "gif" feature not enabled

* Match signatures, move compile-time feature checks

* Add dummy version of fold_to_gif

Author: yanqui-uxo

src/algorithm/media.rs

@@ -18,8 +18,8 @@ use serde::*;
 #[allow(unused_imports)]
 use crate::{Array, Uiua, UiuaResult, Value};
 #[cfg(feature = "gif")]
-use crate::{ArrayValue, RealArrayValue, SigNode};
-use crate::{Complex, OptionalArg, Shape, SysBackend};
+use crate::{ArrayValue, RealArrayValue};
+use crate::{Complex, OptionalArg, Shape, SigNode, SysBackend};
 
 use super::monadic::hsv_to_rgb;
 
@@ -104,7 +104,7 @@ impl SmartOutput {
         Self::Normal(value.show())
     }
     #[cfg(not(feature = "gif"))]
-    fn try_gif(value: &Value, frame_rate: f64) -> Option<Self> {
+    fn try_gif(_value: &Value, _frame_rate: f64) -> Option<Self> {
         None
     }
     #[cfg(feature = "gif")]
@@ -127,7 +127,7 @@ impl SmartOutput {
         }
     }
     #[cfg(not(feature = "apng"))]
-    fn try_apng(value: &Value, frame_rate: f64) -> Option<Self> {
+    fn try_apng(_value: &Value, _frame_rate: f64) -> Option<Self> {
         None
     }
     #[cfg(feature = "apng")]
@@ -346,6 +346,16 @@ pub fn rgba_image_to_array(image: image::RgbaImage) -> Array<f64> {
     )
 }
 
+#[doc(hidden)]
+#[cfg(not(feature = "image"))]
+pub fn image_bytes_to_array(
+    _bytes: &[u8],
+    _gray: bool,
+    _alpha: bool,
+) -> Result<Array<f64>, String> {
+    Err("Decoding images is not supported in this environment".into())
+}
+
 #[doc(hidden)]
 #[cfg(feature = "image")]
 pub fn image_bytes_to_array(bytes: &[u8], gray: bool, alpha: bool) -> Result<Array<f64>, String> {
@@ -626,7 +636,7 @@ pub fn stereo_to_wave_bytes<T: hound::Sample + Copy>(
 
 #[cfg(not(feature = "audio_encode"))]
 #[doc(hidden)]
-pub fn array_from_wav_bytes(bytes: &[u8]) -> Result<(Array<f64>, u32), String> {
+pub fn array_from_wav_bytes(_bytes: &[u8]) -> Result<(Array<f64>, u32), String> {
     Err("Audio decoding is not supported in this environment".into())
 }
 
@@ -842,6 +852,11 @@ fn dither(mut img: image::RgbaImage, width: u32, height: u32) -> (Vec<u8>, bool)
     (buffer, has_transparent)
 }
 
+#[cfg(not(feature = "gif"))]
+pub(crate) fn fold_to_gif(_f: SigNode, env: &mut Uiua) -> UiuaResult<Vec<u8>> {
+    Err(env.error("GIF encoding is not supported in this environment"))
+}
+
 #[cfg(feature = "gif")]
 pub(crate) fn fold_to_gif(f: SigNode, env: &mut Uiua) -> UiuaResult<Vec<u8>> {
     use crate::algorithm::{FixedRowsData, fixed_rows};
@@ -1006,24 +1021,24 @@ where
 
 #[doc(hidden)]
 #[cfg(not(feature = "gif"))]
-pub fn gif_bytes_to_value(_bytes: &[u8]) -> Result<(f64, Value), gif::DecodingError> {
-    Err(env.error("GIF decoding is not supported in this environment"))
-}
-
-#[cfg(not(feature = "gif"))]
-pub(crate) fn gif_bytes_to_value(_bytes: &[u8]) -> Result<(f64, Value), gif::DecodingError> {
-    Err(env.error("GIF decoding is not supported in this environment"))
+pub fn gif_bytes_to_value(_bytes: &[u8]) -> Result<(f64, Value), String> {
+    Err("GIF decoding is not supported in this environment".into())
 }
 
 #[doc(hidden)]
 #[cfg(feature = "gif")]
-pub fn gif_bytes_to_value(bytes: &[u8]) -> Result<(f64, Value), gif::DecodingError> {
-    gif_bytes_to_value_impl(bytes, gif::ColorOutput::RGBA)
+pub fn gif_bytes_to_value(bytes: &[u8]) -> Result<(f64, Value), String> {
+    gif_bytes_to_value_impl(bytes, gif::ColorOutput::RGBA).map_err(|e| e.to_string())
+}
+
+#[cfg(not(feature = "gif"))]
+pub(crate) fn gif_bytes_to_value_gray(_bytes: &[u8]) -> Result<(f64, Value), String> {
+    Err("GIF decoding is not supported in this environment".into())
 }
 
 #[cfg(feature = "gif")]
-pub(crate) fn gif_bytes_to_value_gray(bytes: &[u8]) -> Result<(f64, Value), gif::DecodingError> {
-    gif_bytes_to_value_impl(bytes, gif::ColorOutput::Indexed)
+pub(crate) fn gif_bytes_to_value_gray(bytes: &[u8]) -> Result<(f64, Value), String> {
+    gif_bytes_to_value_impl(bytes, gif::ColorOutput::Indexed).map_err(|e| e.to_string())
 }
 
 #[doc(hidden)]

src/constant.rs

@@ -108,8 +108,7 @@ impl ConstantValue {
                                     media::image_bytes_to_array(&bytes, true, false)?.into()
                                 }
                                 BigConstant::BadAppleGif => {
-                                    let (_, mut val) = media::gif_bytes_to_value_gray(&bytes)
-                                        .map_err(|e| e.to_string())?;
+                                    let (_, mut val) = media::gif_bytes_to_value_gray(&bytes)?;
                                     let Value::Byte(_) = &mut val else {
                                         return Err(
                                             "Bad Apple gif data is not properly rounded to 0 or 1"