diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 6f9258d..3e36617 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,7 +1,6 @@ repos: - repo: https://github.com/uktrade/github-standards - rev: v1.1.2 + rev: v1.2.1 hooks: - id: validate-security-scan - - id: run-security-scan - - id: run-personal-data-scan \ No newline at end of file + - id: run-security-scan \ No newline at end of file diff --git a/SECURITY_CHECKLIST.md b/SECURITY_CHECKLIST.md index 178099e..d5ea50d 100644 --- a/SECURITY_CHECKLIST.md +++ b/SECURITY_CHECKLIST.md @@ -45,6 +45,8 @@ A set of github tags have been created at an organisation level, these must be a ## Apply the correct github security policy +**You must be an organisation administrator to apply this policy** + To add the new security policy, follow these instructions: 1. As an organisation administrator, navigate to the [security config page](https://github.com/organizations/uktrade/settings/security_products). @@ -86,11 +88,11 @@ Internal contributors to the repository should review the [GitHub Safety Tips](h To ensure correct governance of a repository, at least one steward must be added. This will usually be the most senior engineer on the team. To add a steward to a repository: -1. Open the `Collaborators and teams` settings page. The url for this is `https://github.com/uktrade/REPO_NAME/github-standards/settings/access` -1. Use the `Add people` button to open the people finder autocomplete box. -1. Find and click the user who is going to be a steward -1. On the Choose a role page, select the `Steward` role. -1. Repeat for any additional users who are going to be a steward +1. Open the `Collaborators and teams` settings page. The url for this is `https://github.com/uktrade/REPO_NAME/settings/access` +2. Use the `Add people` button to open the people finder autocomplete box. +3. Find and click the user who is going to be a steward +4. On the Choose a role page, select the `Steward` role. +5. Repeat for any additional users who are going to be a steward ## Review and limit maintainers with admin rights to the strict minimum