chore(merge): merge feat-query-lib into j-db-fix-65

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: abnegate

CHANGELOG.md

@@ -321,6 +321,9 @@ have to make, with the 7.x and 8.0 forms side by side.
 - The protected adapter methods nothing called: `getSQLIndexType()` on `SQL` and `SQLite`,
   `Postgres::getSQLSchema()`, `Postgres::encodeArray()`, `Postgres::decodeArray()` and
   `Memory::unregisterRelationshipField()`. See [Removed adapter methods](UPGRADE.md#removed-adapter-methods).
+- `Adapter\SQL::setFloatPrecision()`, `Adapter\SQLite::getEmulateMySQL()`, `Database::getInstanceFilters()`,
+  `Mirror::getWriteFilters()` and `Validator\Structure::getFormats()`, which nothing calls. See
+  [Removed unused public methods](UPGRADE.md#removed-unused-public-methods).
 
 ### Fixed
 

UPGRADE.md

@@ -17,6 +17,7 @@ to 8.0. [CHANGELOG.md](CHANGELOG.md) lists everything that is new in 8.0.
 - [Adapters](#adapters)
 - [Mirror](#mirror)
 - [Validators and helpers](#validators-and-helpers)
+- [Removed unused public methods](#removed-unused-public-methods)
 - [Rules for features new in 8.0](#rules-for-features-new-in-80)
 - [Known limitations](#known-limitations)
 
@@ -1161,6 +1162,18 @@ in 7.x, ahead of the registered `Transform` hooks.
   too; aggregates and selects in the list are left as they are. Without it the method converts as before.
 - `Utopia\Database\Storage::joinAlias()` returns the alias an undeclared join is read under (`j0`, `j1`, ...).
 
+## Removed unused public methods
+
+Nothing in the library, Appwrite, Appwrite Cloud or utopia-php/migration calls these 7.x methods.
+
+| Removed | Replacement |
+|---|---|
+| `Adapter\SQL::setFloatPrecision(int $precision)` | Floats are bound with 17 digits. A subclass can set the protected `$floatPrecision` property |
+| `Adapter\SQLite::getEmulateMySQL()` | `setEmulateMySQL()` is kept. A subclass reads the protected `$emulateMySQL` property |
+| `Database::getInstanceFilters()` | The `$filters` given to the constructor. A subclass reads the protected `$instanceFilters` property |
+| `Mirror::getWriteFilters()` | The `$filters` given to the constructor. A subclass reads the protected `$writeFilters` property |
+| `Validator\Structure::getFormats()` | `Structure::hasFormat($name, $type)` and `Structure::getFormat($name, $type)` |
+
 ## Rules for features new in 8.0
 
 These features do not exist in 7.x. Their rules are listed here because they differ from what a reader of the 7.x

src/Database/Adapter/SQL.php

@@ -220,14 +220,6 @@ public static function getPDOAttributes(): array
         ];
     }
 
-    /**
-     * Configure float precision for parameter binding/logging.
-     */
-    public function setFloatPrecision(int $precision): void
-    {
-        $this->floatPrecision = $precision;
-    }
-
     /**
      * Helper to format a float value according to configured precision for binding/logging.
      */

src/Database/Adapter/SQLite.php

@@ -213,11 +213,6 @@ public function setEmulateMySQL(bool $emulate): static
         return $this;
     }
 
-    public function getEmulateMySQL(): bool
-    {
-        return $this->emulateMySQL;
-    }
-
     public function setTenant(int|string|null $tenant): bool
     {
         $changed = $this->currentTenant() !== $tenant;

src/Database/Database.php

@@ -1840,16 +1840,6 @@ public function skipFilters(callable $callback, ?array $filters = null): mixed
         );
     }
 
-    /**
-     * Get instance filters
-     *
-     * @return array<string, array{encode: callable, decode: callable, signature: string}>
-     */
-    public function getInstanceFilters(): array
-    {
-        return $this->instanceFilters;
-    }
-
     /**
      * Encode Document
      *

src/Database/Hook/Relationships.php

@@ -224,14 +224,6 @@ public function shouldCheckExist(): bool
         return $this->checkExist->get();
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    public function setCheckExist(bool $check): void
-    {
-        $this->checkExist->set($check);
-    }
-
     /**
      * Run the callback with existence checks on or off for the calling coroutine and the coroutines it starts.
      *

src/Database/Mirror.php

@@ -129,14 +129,6 @@ public function getDestination(): ?Database
         return $this->destination;
     }
 
-    /**
-     * @return array<Filter>
-     */
-    public function getWriteFilters(): array
-    {
-        return $this->writeFilters;
-    }
-
     /**
      * @param  callable(string, Throwable): void  $callback
      */

src/Database/Validator/Structure.php

@@ -140,16 +140,6 @@ public function __construct(
         $this->storedAttributes = \array_fill_keys($storedAttributes, true);
     }
 
-    /**
-     * Remove a Validator
-     *
-     * @return array<string, array{callback: callable, type: string}>
-     */
-    public static function getFormats(): array
-    {
-        return self::$formats;
-    }
-
     /**
      * Add a new Validator
      * Stores a callback and required params to create Validator

tests/unit/Relationships/PreparedCreateTest.php

@@ -116,7 +116,12 @@ public function testImmediateCreateMatchesOneByOne(string $engine, string $scena
         $immediate = $this->observe($engine, self::IMMEDIATE, $scenario);
 
         if (isset($immediate['thrown']) && $immediate['inputs'] !== $oneByOne['inputs']) {
-            $this->assertSame(\array_slice($immediate['given'], 1), \array_slice($immediate['inputs'], 1), 'A failed write left the related documents it was given changed');
+            $given = $immediate['given'];
+            $inputs = $immediate['inputs'];
+            if (! \is_array($given) || ! \is_array($inputs)) {
+                $this->fail('An observation lacks the documents handed in');
+            }
+            $this->assertSame(\array_slice($given, 1), \array_slice($inputs, 1), 'A failed write left the related documents it was given changed');
             unset($oneByOne['inputs'], $immediate['inputs']);
         }
 
@@ -679,7 +684,7 @@ private function stored(Database $database): array
             $stored = [];
             foreach ($collections as $collection) {
                 $rows = $database->find($collection, [Query::limit(1000), Query::orderAsc('$sequence')]);
-                $stored[$collection] = \array_map($this->export(...), $rows);
+                $stored[$collection] = \array_values(\array_map($this->export(...), $rows));
             }
 
             return $stored;