(fix): normalize Document attributes in Collection

PHPStan rejected Collection constructors that still received
attribute/index Documents from older tests. Collection now converts
those to Attribute and Index on construct.

Author: abnegate

src/Database/Collection.php

@@ -10,20 +10,38 @@
 class Collection
 {
     /**
-     * @param  array<Attribute>  $attributes
-     * @param  array<Index>  $indexes
+     * @var array<Attribute>
+     */
+    public array $attributes = [];
+
+    /**
+     * @var array<Index>
+     */
+    public array $indexes = [];
+
+    /**
+     * @param  array<Attribute|Document>  $attributes
+     * @param  array<Index|Document>  $indexes
      * @param  array<string>  $permissions
      * @param  array<string, mixed>  $metadata
      */
     public function __construct(
         public string $id = '',
         public string $name = '',
-        public array $attributes = [],
-        public array $indexes = [],
+        array $attributes = [],
+        array $indexes = [],
         public array $permissions = [],
         public bool $documentSecurity = true,
         public array $metadata = [],
     ) {
+        $this->attributes = array_values(array_map(
+            fn (Attribute|Document $attr): Attribute => $attr instanceof Attribute ? $attr : Attribute::fromDocument($attr),
+            $attributes,
+        ));
+        $this->indexes = array_values(array_map(
+            fn (Index|Document $idx): Index => $idx instanceof Index ? $idx : Index::fromDocument($idx),
+            $indexes,
+        ));
     }
 
     /**

src/Database/Traits/Collections.php

@@ -55,9 +55,6 @@ public function createCollection(Collection $collection): Document
         $documentSecurity = $collection->documentSecurity;
         $metadata = $collection->metadata;
 
-        $attributes = array_map(fn ($attr): Attribute => $attr instanceof Attribute ? $attr : Attribute::fromDocument($attr), $attributes);
-        $indexes = array_map(fn ($idx): Index => $idx instanceof Index ? $idx : Index::fromDocument($idx), $indexes);
-
         foreach ($attributes as $attribute) {
             if (in_array($attribute->type, [ColumnType::Point, ColumnType::Linestring, ColumnType::Polygon, ColumnType::Vector, ColumnType::Object], true)) {
                 $existingFilters = $attribute->filters;

tests/unit/CollectionModelTest.php

@@ -28,6 +28,36 @@ public function testConstructorDefaults(): void
         $this->assertSame([], $collection->metadata);
     }
 
+    public function testConstructorNormalizesDocumentAttributesAndIndexes(): void
+    {
+        $collection = new Collection(
+            id: 'nested',
+            attributes: [
+                new Document([
+                    '$id' => 'name',
+                    'type' => 'string',
+                    'size' => 64,
+                    'required' => true,
+                ]),
+            ],
+            indexes: [
+                new Document([
+                    '$id' => 'idx_name',
+                    'key' => 'idx_name',
+                    'type' => 'key',
+                    'attributes' => ['name'],
+                    'lengths' => [64],
+                    'orders' => ['ASC'],
+                ]),
+            ],
+        );
+
+        $this->assertInstanceOf(Attribute::class, $collection->attributes[0]);
+        $this->assertSame('name', $collection->attributes[0]->key);
+        $this->assertInstanceOf(Index::class, $collection->indexes[0]);
+        $this->assertSame('idx_name', $collection->indexes[0]->key);
+    }
+
     public function testConstructorWithValues(): void
     {
         $attr = Attribute::string(key: 'title', size: 128);