Skip to content

Commit e3856a0

Browse files
abnegateclaude
andcommitted
style(adapter): mark Pool's overrides and use full-word names in the touched write paths
Every Pool method that overrides or implements an Adapter method now carries #[\Override], so a renamed or removed Adapter method fails loudly at the Pool subclasses consumers keep (appwrite and cloud override delegate, borrowAndInvoke, syncBorrowed and friends). ReadWritePool already marked all of its own. $attr, $spatialCol, $colName, $col, $docAttrs, $filteredAttr, $filteredCol, $opResult and $intBools become full words in the MariaDB/Postgres create paths and SQL::executeUpsertBatch(), whose narrating comments go. SQLite::bindOperatorParameters() loses its narrating comments; the one invariant they carried (Toggle, DateSetNow and ArrayUnique bind nothing because getOperatorSql() advances the bind index for them) stays in its docblock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 99e29f1 commit e3856a0

5 files changed

Lines changed: 89 additions & 59 deletions

File tree

‎src/Database/Adapter/MariaDB.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -644,10 +644,10 @@ public function createDocument(Document $collection, Document $document): Docume
644644

645645
$spatialMap = \array_fill_keys($spatialAttributes, true);
646646

647-
foreach ($attributes as $attr => $value) {
648-
$column = $this->filter($attr);
647+
foreach ($attributes as $attribute => $value) {
648+
$column = $this->filter($attribute);
649649

650-
if (isset($spatialMap[$attr])) {
650+
if (isset($spatialMap[$attribute])) {
651651
$value = $this->encodeSpatialWriteValue($value);
652652
$value = (\is_bool($value)) ? (int) $value : $value;
653653
$row[$column] = $value;

0 commit comments

Comments
 (0)