Commit fe467cd
committed
test(spotbugs): suppress TextToSpeech findings + pre-existing bernardladenthin#266/bernardladenthin#267 findings
SpotBugs (effort=Max) flagged 5 Low/High findings; all are established
false-positive categories already suppressed elsewhere with the same rationale:
This PR (TextToSpeech, a native-handle wrapper like LlamaModel):
- IMC_IMMATURE_CLASS_NO_TOSTRING — only field is the opaque native handle; a
toString would emit just a pointer (mirrors the LlamaModelBackend suppression).
- WEM_WEAK_EXCEPTION_MESSAGING on synthesize() — fixed "TextToSpeech is closed"
precondition guard (mirrors the server request-parser guards).
Pre-existing on main from the merged bernardladenthin#266/bernardladenthin#267 (this branch inherits them via the
rebase; main is also red on them):
- OpenAiRequestMapper.toCompletionParameters WEM — same input-validation guard as
the already-suppressed toInferenceParameters; extended the existing Or-block.
- ContentPart.inputAudio IMPROPER_UNICODE + LSC_LITERAL_STRING_COMPARISON — the
canonical toLowerCase(Locale.ROOT)+equals format validation over a fixed ASCII
pair; same false-positive class as the server.* IMPROPER_UNICODE block.
Verified locally: mvn spotbugs:check -> BUILD SUCCESS (0 bugs).1 parent f6d1e91 commit fe467cd
1 file changed
Lines changed: 42 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
440 | 459 | | |
441 | 460 | | |
442 | 461 | | |
| |||
471 | 490 | | |
472 | 491 | | |
473 | 492 | | |
474 | | - | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
475 | 497 | | |
476 | 498 | | |
477 | 499 | | |
| |||
549 | 571 | | |
550 | 572 | | |
551 | 573 | | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
552 | 593 | | |
0 commit comments