SQL parameters are not logged

[axelson]

With {Timber.Integrations.EctoLogger, :log, []} listed in the :loggers key for my Ecto Repository I see log statements like this:

[debug] Processed SELECT c0."id", c0."name" FROM "communities" AS c0 WHERE (c0."id" = $1) in 3ms

But I would expect to see the value of the parameters (in this case it is $1). Is there a reason that they are hidden? Can they be added back? (note: by default they are logged by Ecto).

[binarylogic]

Hey @axelson, great request / issue. Ecto constructs what are called prepared statements which are primarily used to protect against SQL injections and improve performance. This is why you see $1, $2, etc. What Ecto does provide are the query parameters. We can make that an option to include as metadata for the sql_query event. This way you can see the values when you inspect the log line. Would that be sufficient?

[axelson]

Yes that would be great since that is similar to what Ecto logs by default.