Skip to content

Commit a0c41e1

Browse files
Michael Wilsonchromium-wpt-export-bot
authored andcommitted
Update sample rate range in audiocontextoptions.html
The specification is being updated to put different requirements on the sample rate in WebAudio. Update the WPT to reflect this. See WebAudio/web-audio-api#2657 Change-Id: Ic99a306da2cf625b52168c4143c0a3320aef1087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7204605 Reviewed-by: Hongchan Choi <[email protected]> Commit-Queue: Hongchan Choi <[email protected]> Cr-Commit-Position: refs/heads/main@{#1555679}
1 parent 3c708b0 commit a0c41e1

File tree

1 file changed

+38
-15
lines changed

1 file changed

+38
-15
lines changed

webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html

Lines changed: 38 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -163,39 +163,62 @@
163163
'Test creating contexts with non-default sampleRate values.'
164164
},
165165
function(task, should) {
166-
// A sampleRate of 1 is unlikely to be supported on any browser,
167-
// test that this rate is rejected.
166+
// A negative sample rate should not be accepted
168167
should(
169168
() => {
170-
context = new AudioContext({sampleRate: 1})
169+
context = new AudioContext({sampleRate: -1})
171170
},
172-
'context = new AudioContext({sampleRate: 1})')
171+
'context = new AudioContext({sampleRate: -1})')
173172
.throw(DOMException, 'NotSupportedError');
174173

175-
// A sampleRate of 1,000,000 is unlikely to be supported on any
176-
// browser, test that this rate is also rejected.
174+
// A null sample rate should not be accepted
177175
should(
178176
() => {
179-
context = new AudioContext({sampleRate: 1000000})
177+
context = new AudioContext({sampleRate: 0})
180178
},
181-
'context = new AudioContext({sampleRate: 1000000})')
179+
'context = new AudioContext({sampleRate: 0})')
182180
.throw(DOMException, 'NotSupportedError');
183-
// A negative sample rate should not be accepted
181+
182+
183+
// A sampleRate oustide the range 3000 to 768000 must be rejected
184184
should(
185185
() => {
186-
context = new AudioContext({sampleRate: -1})
186+
context = new AudioContext({sampleRate: 2999})
187187
},
188-
'context = new AudioContext({sampleRate: -1})')
188+
'context = new AudioContext({sampleRate: 2999})')
189189
.throw(DOMException, 'NotSupportedError');
190-
// A null sample rate should not be accepted
191-
should(
190+
191+
should(
192192
() => {
193-
context = new AudioContext({sampleRate: 0})
193+
context = new AudioContext({sampleRate: 768001})
194194
},
195-
'context = new AudioContext({sampleRate: 0})')
195+
'context = new AudioContext({sampleRate: 768001})')
196196
.throw(DOMException, 'NotSupportedError');
197197

198+
// A sampleRate in the range 3000 to 768000 must be accepted
199+
should(
200+
() => {
201+
context = new AudioContext({sampleRate: 3000})
202+
},
203+
'context = new AudioContext({sampleRate: 3000})')
204+
.notThrow();
205+
should(
206+
context.sampleRate, 'sampleRate inrange')
207+
.beEqualTo(3000);
208+
context.close();
209+
210+
should(
211+
() => {
212+
context = new AudioContext({sampleRate: 768000})
213+
},
214+
'context = new AudioContext({sampleRate: 768000})')
215+
.notThrow();
198216
should(
217+
context.sampleRate, 'sampleRate inrange')
218+
.beEqualTo(768000);
219+
context.close();
220+
221+
should(
199222
() => {
200223
context = new AudioContext({sampleRate: 24000})
201224
},

0 commit comments

Comments
 (0)