Map CSS-column-related tests to web-features #56533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@foolip @jcscottiii This patch started with
column-breaksand only got uglier from there. A strict reading of the web-feature descriptions suggests that they are specifically about the usage of the CSS properties, and that the values of the defaults is not part of the feature.This may sound like a pedantic reading (it sure felt that way to me at first), but I think it mimics how developers likely think of the features. Since they observe the behavior of
column-fill: balancewhenever they use columns, "column fill" is really specifically aboutcolumn-fill: auto.Unfortunately, the tests aren't organized along this distinction, so reflecting it has necessitated lengthy and brittle selectors. Compounding this problem is the presence of
multi-column, which is effectively an inversion of the other fiddly classifiers.Does this seem like the right approach to you?